Closed zwarm closed 3 weeks ago
2 Warnings | |
---|---|
:warning: | This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews. |
:warning: | Class RestartEditorOptions is missing tests, but unit-tests-exemption label was set to ignore this. |
Generated by :no_entry_sign: Danger
App Name | Jetpack | |
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr20543-25d7cb9 | |
Commit | 25d7cb9760b435b2cd9f21318aacd948b6d695cf | |
Direct Download | jetpack-prototype-build-pr20543-25d7cb9.apk |
App Name | WordPress | |
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr20543-25d7cb9 | |
Commit | 25d7cb9760b435b2cd9f21318aacd948b6d695cf | |
Direct Download | wordpress-prototype-build-pr20543-25d7cb9.apk |
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 40.32%. Comparing base (
21bf822
) to head (25d7cb9
). Report is 5 commits behind head on trunk.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Issues
27 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
This pull request was deployed and Sentry observed the following issues:
org.wordpress.android.ui.uploads.UploadService ...
View IssueDid you find this useful? React with a 👍 or 👎
Fixes #20509
This PR marks the initial phase in simplifying the complexity of
EditPostActivity
.In this PR is the conversion of
EditPostActivity
from Java to Kotlin. While Android Studio handled the bulk of the conversion, I manually did a bunch of cleanup to minimize the need for "most" suppressions. The lingering suppressions, includeCyclomaticComplexMethod
,ReturnCount
,LargeMethod
, andLargeClass
. They will be addressed outside of this PR.The ultimate objective is to refactor this class into coherent segments, streamlining the activity into a more manageable and maintainable structure.
The UI was not touched during this conversion
To Test:
Using the branch from this PR, thoroughly check the following create/edit post scenarios (and any others you can think of)
✅ Verify you can create a post
✅ Verify you can edit a post
✅ Verify you can edit post setting from within the edit post view
✅ Verify you can edit change the publish post settings
✅ Verify you can create/edit a post with images, galleries
✅ Verify you can create/edit a post with videos
✅ Verify your work is auto saved (use the web to look for changes)
✅ Verify you can return from background
✅ Verify you can save a post as a draft
✅ Verify you can't publish a post when media is uploading
✅ Verify you can set a featured image
✅ Verify CI passed the unit tests
✅ Verify CI passed the instrumentation tests
Regression Notes
Potential unintended areas of impact Edit post activities no longer work
What I did to test those areas of impact (or what existing automated tests I relied on) Manual testing of edit posts. No unit tests exist because it's an activity
What automated tests I added (or what prevented me from doing so) The existing instrumentation tests.
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):