wordpress-mobile / WordPress-Android

WordPress for Android
http://android.wordpress.org
GNU General Public License v2.0
2.92k stars 1.3k forks source link

[Reader] Scroll post list to top when Reader tab is tapped #20544

Closed RenanLukas closed 1 month ago

RenanLukas commented 1 month ago

Fixes #15175


To Test:

  1. Install JP and sign in.
  2. Open Reader.
  3. 🔍 Open different feeds, scroll down to any point and tap the "Reader" tab in bottom navigation: the list should be scrolled to top and AppBar should be expanded.

Regression Notes

  1. Potential unintended areas of impact

    • None
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Manual testing
  3. What automated tests I added (or what prevented me from doing so)

    --


PR Submission Checklist:


Testing Checklist (strike-out the not-applying and unnecessary ones):

dangermattic commented 1 month ago
1 Warning
:warning: PR is not assigned to a milestone.

Generated by :no_entry_sign: Danger

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

wpmobilebot commented 1 month ago
WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20544-00e8f7f
Commit00e8f7f002837f625bb91ae77b68914e38a8fdfa
Direct Downloadwordpress-prototype-build-pr20544-00e8f7f.apk
Note: Google Login is not supported on these builds.
wpmobilebot commented 1 month ago
Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20544-00e8f7f
Commit00e8f7f002837f625bb91ae77b68914e38a8fdfa
Direct Downloadjetpack-prototype-build-pr20544-00e8f7f.apk
Note: Google Login is not supported on these builds.
osullivanchris commented 1 month ago

per our hangout I'm keen to have this on other tabs as well.

FYI this also came up within comments (which may now be at the bottom of a reader view in future) - which is slightly trickier to solve, as its not at the root level so can't solve by tapping the bottom tab bar.

I was playing around with this today where the title of the post would collapse into the navigation bar, and be tappable to scroll to the top. I don't love it yet though.

Screenshot 2024-03-28 at 16 08 10

I also tried with a bit of UI at the bottom of the screen but it was a bit heavy.

Screenshot 2024-03-28 at 16 09 17