wordpress-mobile / WordPress-Android

WordPress for Android
http://android.wordpress.org
GNU General Public License v2.0
2.92k stars 1.3k forks source link

feat: assign "debug" release, when app is not in `release` variant #20545

Closed wzieba closed 1 month ago

wzieba commented 1 month ago

Description

This PR bumps Tracks to 4.0.2. The major change here is that we delegate creating a release name to Tracks library (Sentry internally), instead of providing value from our build config.

This will address a problem of matching a release with the same name from different projects in the same Sentry organization.

Additionally, in debug/PR builds, we'll assign a debug release. This way, we'll clean up Sentry dashboard, as currently we have dozens of "pr-0000-00000" releases.


To Test:

Screen from a test issue on release build type:

Screenshot 2024-03-27 at 19 47 23

and on debug build type:

image


Regression Notes

  1. Potential unintended areas of impact

    • Assigning incorrect release name to an issue
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Test Sentry issues, see above
  3. What automated tests I added (or what prevented me from doing so)

    • Unit tests

PR Submission Checklist:


Testing Checklist (strike-out the not-applying and unnecessary ones):

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

wpmobilebot commented 1 month ago

Found 1 violations:

The PR caused some dependency changes (expand to see details)

```diff +--- project :libs:analytics -| \--- com.automattic:Automattic-Tracks-Android:3.6.0 +| \--- com.automattic:Automattic-Tracks-Android:4.0.2 +--- project :libs:editor -| \--- com.automattic:Automattic-Tracks-Android:3.6.0 (*) +| \--- com.automattic:Automattic-Tracks-Android:4.0.2 (*) -\--- com.automattic:Automattic-Tracks-Android:{strictly 3.6.0} -> 3.6.0 (*) +\--- com.automattic:Automattic-Tracks-Android:{strictly 4.0.2} -> 4.0.2 (*) ```

Please review and act accordingly

wpmobilebot commented 1 month ago
WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20545-293969a
Commit293969ad92c67924cadf39dab22eaff2e8b1e5c3
Direct Downloadwordpress-prototype-build-pr20545-293969a.apk
Note: Google Login is not supported on these builds.
wpmobilebot commented 1 month ago
Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20545-293969a
Commit293969ad92c67924cadf39dab22eaff2e8b1e5c3
Direct Downloadjetpack-prototype-build-pr20545-293969a.apk
Note: Google Login is not supported on these builds.
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 40.24%. Comparing base (569b0a4) to head (293969a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## trunk #20545 +/- ## ======================================= Coverage 40.24% 40.24% ======================================= Files 1463 1463 Lines 67600 67602 +2 Branches 11201 11202 +1 ======================================= + Hits 27205 27207 +2 Misses 37934 37934 Partials 2461 2461 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sentry-io[bot] commented 3 weeks ago

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎