wordpress-mobile / WordPress-Android

WordPress for Android
http://android.wordpress.org
GNU General Public License v2.0
2.92k stars 1.3k forks source link

Fix for auto-scrolling issues on stats screen #20546

Closed irfano closed 1 month ago

irfano commented 1 month ago

Fixes #20523

This fixes auto-scrolling issues on the stats screen.

Changes made:


To Test:

Test this with both stats_traffic_enabled is off and on cases.

  1. Log in.
  2. Open "My Site → Stats".
  3. Test the changes listed above.

Regression Notes

  1. Potential unintended areas of impact

    • There may be some issues related to updating cards.
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Tested manually.
  3. What automated tests I added (or what prevented me from doing so)

    • The behavior changes are minor and not suitable for UI tests.

PR Submission Checklist:


Testing Checklist (strike-out the not-applying and unnecessary ones):

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

wpmobilebot commented 1 month ago
Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20546-ff4f403
Commitff4f40355d01b6ddc62dd14a5653742fe65039a5
Direct Downloadjetpack-prototype-build-pr20546-ff4f403.apk
Note: Google Login is not supported on these builds.
wpmobilebot commented 1 month ago
WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20546-ff4f403
Commitff4f40355d01b6ddc62dd14a5653742fe65039a5
Direct Downloadwordpress-prototype-build-pr20546-ff4f403.apk
Note: Google Login is not supported on these builds.
irfano commented 1 month ago

It was meant for Scrolling to a a new card on INSIGHTS, and wasn't working well anyways!

Yes, I intentionally wanted to remove that behavior. Users can add or remove multiple cards, and I don't see the benefit of changing the scroll position after replacing cards.