wordpress-mobile / WordPress-Android

WordPress for Android
http://android.wordpress.org
GNU General Public License v2.0
2.92k stars 1.3k forks source link

Fix scrolling issue occurs when opening granular tabs on stats screen #20551

Closed irfano closed 1 month ago

irfano commented 1 month ago

This fixes the scrolling issue that occurs when opening granular tabs on the stats screen. The issue was introduced with https://github.com/wordpress-mobile/WordPress-Android/pull/20546.

Issue video:

scroll-issue.webm


To Test:

  1. Log in.
  2. Open "My Site → Stats".
  3. Switch to tabs other than INSIGHTS.
  4. Verify that the scrolling position is at the top.
  5. Navigate back and repeat 2-3 a couple of times.
  6. Repeat 4.

Regression Notes

  1. Potential unintended areas of impact

    • None
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • N/A
  3. What automated tests I added (or what prevented me from doing so)

    • The behavior changes are minor and not suitable for UI tests.

PR Submission Checklist:


Testing Checklist (strike-out the not-applying and unnecessary ones):

dangermattic commented 1 month ago
1 Warning
:warning: This PR is assigned to the milestone 24.6. This milestone is due in less than 4 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by :no_entry_sign: Danger

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

wpmobilebot commented 1 month ago
WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20551-a420377
Commita420377e584f6d151efc0f3f9b6da9c3d4021efc
Direct Downloadwordpress-prototype-build-pr20551-a420377.apk
Note: Google Login is not supported on these builds.
wpmobilebot commented 1 month ago
Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20551-a420377
Commita420377e584f6d151efc0f3f9b6da9c3d4021efc
Direct Downloadjetpack-prototype-build-pr20551-a420377.apk
Note: Google Login is not supported on these builds.