[Reader Customization] Save reading preferences with device or app back buttons

thomashorta commented 1 month ago

[!Warning] This should only be merged after https://github.com/wordpress-mobile/WordPress-Android/pull/20506

~Add a "Done" button for saving Reader preferences instead of relying on the top app bar "back" button.~

After some discussion (p1711720310041669-slack-C06PGTY5PKK), it was decided to keep the dialog without a "Done" button and, instead, make sure both the system's back button and the top app bar back button save the preferences before exiting.

To Test:

Since the feature is still in development, follow the initial instructions in the "To Test" section of https://github.com/wordpress-mobile/WordPress-Android/pull/20506

Go to Reader
Open any post
Open the Reading Preferences sheet (icon on top bar)
Change the preferences
Tap the system's back button
Verify it saves the preferences accordingly
Open the Reading Preferences sheet again
Change the preferences
Tap the back arrow on the top bar
Verify it also saves the preferences

Regression Notes

Potential unintended areas of impact
- N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
- N/A
What automated tests I added (or what prevented me from doing so)
- N/A

PR Submission Checklist:

[x] I have completed the Regression Notes.
[x] I have considered adding accessibility improvements for my changes.
[x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

[ ] ~WordPress.com sites and self-hosted Jetpack sites.~
[x] Portrait and landscape orientations. (there are bugs in landscape but not due to this PR, will be investigated and fixed on a different PR)
[x] Light and dark modes.
[x] Fonts: Larger, smaller and bold text.
[x] High contrast.
[ ] ~Talkback.~ (accessibility will be checked in a different PR)
[ ] ~Languages with large words or with letters/accents not frequently used in English.~
[ ] ~Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)~
[ ] ~Large and small screen sizes. (Tablet and smaller phones)~
[ ] ~Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)~

wpmobilebot commented 1 month ago

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20553-40b24a3
	Commit	40b24a30367cb04f01d0a3e409ed589144f199ef
	Direct Download	`wordpress-prototype-build-pr20553-40b24a3.apk`

Note: Google Login is not supported on these builds.

wpmobilebot commented 1 month ago

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20553-40b24a3
	Commit	40b24a30367cb04f01d0a3e409ed589144f199ef
	Direct Download	`jetpack-prototype-build-pr20553-40b24a3.apk`