Upgrade ucrop library to 2.2.9

irfano commented 1 month ago

Fixes #20570

This updates ucrop library and potentially fixes java.lang.SecurityException on the crop library.

To Test:

Add a new blog post.
Add a new image block.
Choose an image and wait for it to be uploaded within the image block.
Click on the media options of this image (top right) and then click edit.
Crop the image and click the done menu option (top right).
Verify the image is updated accordingly.

Regression Notes

Potential unintended areas of impact
- Cropping image
What I did to test those areas of impact (or what existing automated tests I relied on)
- Tested manually
What automated tests I added (or what prevented me from doing so)
- No test added since this is only a third party lib update.

PR Submission Checklist:

[x] I have completed the Regression Notes.
[x] I have considered adding accessibility improvements for my changes.
[x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

[ ] ~WordPress.com sites and self-hosted Jetpack sites.~
[ ] ~Portrait and landscape orientations.~
[ ] ~Light and dark modes.~
[ ] ~Fonts: Larger, smaller and bold text.~
[ ] ~High contrast.~
[ ] ~Talkback.~
[ ] ~Languages with large words or with letters/accents not frequently used in English.~
[ ] ~Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)~
[ ] ~Large and small screen sizes. (Tablet and smaller phones)~
[ ] ~Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)~

sonarcloud[bot] commented 1 month ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

wpmobilebot commented 1 month ago

Found 1 violations:

The PR caused some dependency changes (expand to see details)

```diff +--- project :libs:image-editor -| \--- com.github.yalantis:ucrop:2.2.8 -| +--- androidx.exifinterface:exifinterface:1.3.2 -> 1.3.6 -| | \--- androidx.annotation:annotation:1.2.0 -> 1.6.0 (*) -| +--- androidx.transition:transition:1.4.1 (*) -| \--- com.squareup.okhttp3:okhttp:3.12.13 -> 4.11.0 (*) +| \--- com.github.yalantis:ucrop:2.2.9 FAILED +--- project :libs:editor | \--- org.wordpress.gutenberg-mobile:react-native-gutenberg-bridge:v1.116.0 | \--- org.wordpress.react-native-libraries.v5:react-native-fast-image:8.5.11 | \--- com.github.bumptech.glide:glide:4.12.0 -> 4.16.0 -| \--- androidx.exifinterface:exifinterface:1.3.6 (*) +| \--- androidx.exifinterface:exifinterface:1.3.6 +| \--- androidx.annotation:annotation:1.2.0 -> 1.6.0 (*) -\--- com.github.yalantis:ucrop:2.2.8 (*) +\--- com.github.yalantis:ucrop:2.2.9 FAILED ```

Please review and act accordingly

irfano commented 1 month ago

This is running on my local but failing on CI. I will investigate the reason.

wpmobilebot commented 2 weeks ago

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20598-5a9eb1e
	Commit	5a9eb1e6cbe6be4ad60ef3e4fed8ed50cfc49128
	Direct Download	`wordpress-prototype-build-pr20598-5a9eb1e.apk`

Note: Google Login is not supported on these builds.

wpmobilebot commented 2 weeks ago

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20598-5a9eb1e
	Commit	5a9eb1e6cbe6be4ad60ef3e4fed8ed50cfc49128
	Direct Download	`jetpack-prototype-build-pr20598-5a9eb1e.apk`

Note: Google Login is not supported on these builds.

irfano commented 2 weeks ago

uCrop 2.2.9 has been uploaded to Maven and can be tested now.

wordpress-mobile / WordPress-Android