Fixes LongMethod detekt issue in AppInitializer.init method

antonis commented 1 month ago

Description

Fixes LongMethod Detekt issue in AppInitializer.init method introduced by merging https://github.com/wordpress-mobile/WordPress-Android/pull/20603 and https://github.com/wordpress-mobile/WordPress-Android/pull/20620 that both extended the method without merging from trunk.

Verify that all CI tests are 🟢

Potential unintended areas of impact
- N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
- Manual testing
What automated tests I added (or what prevented me from doing so)
- N/A

[ ] I have completed the Regression Notes.
[ ] I have considered adding accessibility improvements for my changes.
[ ] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[ ] WordPress.com sites and self-hosted Jetpack sites.
[ ] Portrait and landscape orientations.
[ ] Light and dark modes.
[ ] Fonts: Larger, smaller and bold text.
[ ] High contrast.
[ ] Talkback.
[ ] Languages with large words or with letters/accents not frequently used in English.
[ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
[ ] Large and small screen sizes. (Tablet and smaller phones)
[ ] Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

dangermattic commented 1 month ago

	1 Warning
:warning:	This PR is assigned to the milestone 24.7. This milestone is due in less than 4 days. Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by :no_entry_sign: Danger

sonarcloud[bot] commented 1 month ago

wpmobilebot commented 1 month ago

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20630-5f98281
	Commit	5f982815db48658540340f8a5429613d75144c45
	Direct Download	`wordpress-prototype-build-pr20630-5f98281.apk`

Note: Google Login is not supported on these builds.

wpmobilebot commented 1 month ago

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20630-5f98281
	Commit	5f982815db48658540340f8a5429613d75144c45
	Direct Download	`jetpack-prototype-build-pr20630-5f98281.apk`

Note: Google Login is not supported on these builds.

sentry-io[bot] commented 1 month ago

This pull request was deployed and Sentry observed the following issues:

‼️ RuntimeException: Unable to create application org.wordpress.android.WordPressRelease: java.lang.SecurityException:... android.app.ActivityThread in handleBindApplica... View Issue

_{Did you find this useful? React with a 👍 or 👎}