wordpress-mobile / WordPress-Android

WordPress for Android
http://android.wordpress.org
GNU General Public License v2.0
2.92k stars 1.3k forks source link

Adds: shouldSkipConflictResolutionCheck flag for pages #20632

Closed pantstamp closed 3 weeks ago

pantstamp commented 1 month ago

Fixes #


To Test:


Regression Notes

  1. Potential unintended areas of impact

    • TODO
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • TODO
  3. What automated tests I added (or what prevented me from doing so)

    • TODO

PR Submission Checklist:


Testing Checklist (strike-out the not-applying and unnecessary ones):

dangermattic commented 1 month ago
1 Message
:book: This PR is still a Draft: some checks will be skipped.

Generated by :no_entry_sign: Danger

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

wpmobilebot commented 1 month ago
Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20632-72d1fda
Commit72d1fdacda4bf912da0bcfc6d8112d66ac47c60c
Direct Downloadjetpack-prototype-build-pr20632-72d1fda.apk
Note: Google Login is not supported on these builds.
wpmobilebot commented 1 month ago
WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20632-72d1fda
Commit72d1fdacda4bf912da0bcfc6d8112d66ac47c60c
Direct Downloadwordpress-prototype-build-pr20632-72d1fda.apk
Note: Google Login is not supported on these builds.
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 40.48%. Comparing base (42220a6) to head (72d1fda).

Files Patch % Lines
...oid/ui/posts/PostConflictResolutionFeatureUtils.kt 0.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## trunk #20632 +/- ## ========================================== - Coverage 40.48% 40.48% -0.01% ========================================== Files 1479 1479 Lines 68342 68342 Branches 11290 11290 ========================================== - Hits 27669 27668 -1 Misses 38173 38173 - Partials 2500 2501 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zwarm commented 1 month ago

@pantstamp - let's hold off on this PR - we have the time to address pages in this upcoming sprint