QR Code Scanning: Prevent illegalStateException

zwarm commented 4 weeks ago

Fixes #20643

This PR addresses an issue where the app may encounter an IllegalStateException when attempting to set a fragment result after its lifecycle has reached the STOPPED state or beyond. To prevent this potential issue the following changes have been made:

Changed the lifecycle state in the observeCameraPermissionState from Lifecycle.State.CREATED to Lifecycle.State.STARTED. This ensures that the code block is executed only when the fragment is at least in the STARTED state, eliminating potential IllegalStateExceptions.

Introduced a check for isAdded in the setFragmentResultAndPopStack method. The isAdded property returns true if the fragment is currently added to its activity, providing a way to ensure that the fragment is still attached to its activity before executing UI-related code.

I was unable to recreate this crash, but according to the logs it happens when the app is backgrounded while the scanner is opened for QR Code login.

To Test:

Pre-req

Remove all versions of Jetpack from your device

[JP] Scan Login Code Step.1:

Install the Jetpack app from this PR
Log in to the Jetpack app with a WP.com account (note that you need to use a non A8C account and a non 2FA enabled account).
Navigate to the Me screen (click on bottom Me navigation tab). (STOP)

Step.2:

Head over to your desktop and open a web browser (note that using an incognito tab works best).
Browse to wordpress.com (note that if you are logged-in, log-out first).
Tap the Log In link (top-right).
Tap the Login via the mobile app link in the list of options below the main Continue button (bottom-middle).
Verify you are on the Login via the mobile app view and Use QR Code to login is shown, along with a QR code for you to scan.

(STOP) Step.3:

Head back to your mobile.
Tap the Scan Login Code item on the Me screen you are currently at.
Accept the use camera permissions
Scan the QR code on the web browser.
Follow the remaining prompts on your mobile to log in to WordPress on your web browser (desktop), verify that you have successfully logged-in and are able to use WordPress as expected.

[JP] Super Fast Media Upload

Verify that scanning the super fast media upload qr code works as expected. You do not have to run the entire flow, just scan the barcode to launch the app.

Regression Notes

Potential unintended areas of impact
- Bar scanner no longer works
What I did to test those areas of impact (or what existing automated tests I relied on) Manul testing
What automated tests I added (or what prevented me from doing so) N/A

PR Submission Checklist:

[X] I have completed the Regression Notes.
[X] I have considered adding accessibility improvements for my changes.
[X] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones): N/A

sonarcloud[bot] commented 4 weeks ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

wpmobilebot commented 4 weeks ago

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20650-1cecdbc
	Commit	1cecdbcef88f8eeaffb8d9d78e9aa7f4dec834a4
	Direct Download	`wordpress-prototype-build-pr20650-1cecdbc.apk`

Note: Google Login is not supported on these builds.

wpmobilebot commented 4 weeks ago

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20650-1cecdbc
	Commit	1cecdbcef88f8eeaffb8d9d78e9aa7f4dec834a4
	Direct Download	`jetpack-prototype-build-pr20650-1cecdbc.apk`

Note: Google Login is not supported on these builds.

wordpress-mobile / WordPress-Android