Fixes: NullPointerException in SiteCreationActivity

[pantstamp]

Fixes #20647

---

This PR tries to fix sentry crash reported here.

The issue is in these lines:

supportFragmentManager.findFragmentByTag(JetpackFeatureFullScreenOverlayFragment.TAG)
                    as JetpackFeatureFullScreenOverlayFragment

findFragmentByTag() may return a null value and if we then try to cast null to JetpackFeatureFullScreenOverlayFragment, a NullPointerException is thrown.

I was not able to replicate the crash on my device but it seems that the approach of using savedInstanceState == null check does not work for all cases.

To Test:

1. Install the WordPress apk from this PR.
2. Log in and try to create a new site.
3. When the overlay that promotes Jetpack app appears, rotate your device multiple times and check that no crash occurs.

---

Regression Notes

1. Potential unintended areas of impact

   • JetpackFeatureFullScreenOverlayFragment is not shown

2. What I did to test those areas of impact (or what existing automated tests I relied on)

   • Manual testing

3. What automated tests I added (or what prevented me from doing so)

   • N/A

---

PR Submission Checklist:

• [x] I have completed the Regression Notes.
• [x] I have considered adding accessibility improvements for my changes.
• [x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

---

Testing Checklist (strike-out the not-applying and unnecessary ones):

• [ ] WordPress.com sites and self-hosted Jetpack sites.
• [ ] Portrait and landscape orientations.
• [ ] Light and dark modes.
• [ ] Fonts: Larger, smaller and bold text.
• [ ] High contrast.
• [ ] Talkback.
• [ ] Languages with large words or with letters/accents not frequently used in English.
• [ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• [ ] Large and small screen sizes. (Tablet and smaller phones)
• [ ] Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

[sonarcloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20652-141f222
	Commit	141f222d3d022e5a59ee754c88963ccb5553edc6
	Direct Download	wordpress-prototype-build-pr20652-141f222.apk

Note: Google Login is not supported on these builds.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20652-141f222
	Commit	141f222d3d022e5a59ee754c88963ccb5553edc6
	Direct Download	jetpack-prototype-build-pr20652-141f222.apk

Note: Google Login is not supported on these builds.

[sentry-io[bot]]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ IllegalStateException: Fragment JetpackFeatureFullScreenOverlayFragment{99ea901} (0d965b78-cdab-44fc-8b10-d16115613602) ... org.wordpress.android.ui.sitecreation.SiteCreat... View Issue

_{Did you find this useful? React with a 👍 or 👎}