EditPost: Fix NullPointerException in overriding methods

zwarm commented 3 weeks ago

Fixes #20663

This PR addresses a NullPointerException that occurred in a Kotlin class when overriding a method from a Java interface. The issue was caused by the Kotlin class expecting a non-null parameter for the method, while the Java interface allowed the parameter to be nullable.

To resolve this issue, the method signature in the Kotlin EditPostActivity has been updated to accept a nullable Exception parameter. This change allows the Kotlin class to handle cases where the Java implementation passes a null Exception reference without throwing a NullPointerException.

Note: I was unable to recreate this crash

FYI: @oguzkocer - We are targeting release/24.7 with this fix. I'll post in #app-infrastructure after it's been reviewed

Test

Download the app from this PR
Create and edit a post to ensure it functions correctly.

Regression Notes

Potential unintended areas of impact The NPE is still present
What I did to test those areas of impact (or what existing automated tests I relied on) Relied on existing unit tests
What automated tests I added (or what prevented me from doing so) N/A

PR Submission Checklist:

[X] I have completed the Regression Notes.
[X] I have considered adding accessibility improvements for my changes.
[X] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones): N/A

dangermattic commented 3 weeks ago

	1 Warning
:warning:	This PR is assigned to the milestone 24.7 ❄️. The due date for this milestone has already passed. Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by :no_entry_sign: Danger

sonarcloud[bot] commented 3 weeks ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

wpmobilebot commented 3 weeks ago

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20666-1f25414
	Commit	1f254141b1d5a1f2a652b5f22ee6e0941dbe0737
	Direct Download	`jetpack-prototype-build-pr20666-1f25414.apk`

Note: Google Login is not supported on these builds.

wpmobilebot commented 3 weeks ago

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20666-1f25414
	Commit	1f254141b1d5a1f2a652b5f22ee6e0941dbe0737
	Direct Download	`wordpress-prototype-build-pr20666-1f25414.apk`

Note: Google Login is not supported on these builds.

wordpress-mobile / WordPress-Android