wordpress-mobile / WordPress-Android

WordPress for Android
http://android.wordpress.org
GNU General Public License v2.0
2.92k stars 1.3k forks source link

Fix #20664 - fix crash in WPAvatarUtils #20668

Closed maxme closed 3 weeks ago

maxme commented 3 weeks ago

Fixes #20664


Regression Notes

  1. Potential unintended areas of impact

    • This will have the same behavior as before the Gravatar-SDK-Android integration: if the passed Gravatar URL is invalid (no or empty hash), we'll show the default avatar.
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • I haven't tested manually
  3. What automated tests I added (or what prevented me from doing so)

    • New test added in WPAvatarUtilsTests

PR Submission Checklist:


Testing Checklist (strike-out the not-applying and unnecessary ones):

~- [ ] WordPress.com sites and self-hosted Jetpack sites.~ ~- [ ] Portrait and landscape orientations.~ ~- [ ] Light and dark modes.~ ~- [ ] Fonts: Larger, smaller and bold text.~ ~- [ ] High contrast.~ ~- [ ] Talkback.~ ~- [ ] Languages with large words or with letters/accents not frequently used in English.~ ~- [ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)~ ~- [ ] Large and small screen sizes. (Tablet and smaller phones)~ ~- [ ] Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)~

dangermattic commented 3 weeks ago
1 Warning
:warning: This PR is assigned to the milestone 24.7 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by :no_entry_sign: Danger

sonarcloud[bot] commented 3 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

wpmobilebot commented 3 weeks ago
Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20668-a97c114
Commita97c114118c7d2ad0d68954db95856d0de264de8
Direct Downloadjetpack-prototype-build-pr20668-a97c114.apk
Note: Google Login is not supported on these builds.
wpmobilebot commented 3 weeks ago
WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20668-a97c114
Commita97c114118c7d2ad0d68954db95856d0de264de8
Direct Downloadwordpress-prototype-build-pr20668-a97c114.apk
Note: Google Login is not supported on these builds.
codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 40.46%. Comparing base (687b082) to head (a97c114). Report is 2 commits behind head on release/24.7.

Files Patch % Lines
...java/org/wordpress/android/util/WPAvatarUtils.java 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/24.7 #20668 +/- ## ============================================= Coverage 40.46% 40.46% ============================================= Files 1484 1484 Lines 68416 68416 Branches 11307 11307 ============================================= Hits 27683 27683 Misses 38233 38233 Partials 2500 2500 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.