Closed RenanLukas closed 4 weeks ago
1 Warning | |
---|---|
:warning: | PR is not assigned to a milestone. |
Generated by :no_entry_sign: Danger
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
App Name | Jetpack | |
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr20672-f75300f | |
Commit | f75300f60608624fada4a30b613e31a0b78d3309 | |
Direct Download | jetpack-prototype-build-pr20672-f75300f.apk |
App Name | WordPress | |
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr20672-f75300f | |
Commit | f75300f60608624fada4a30b613e31a0b78d3309 | |
Direct Download | wordpress-prototype-build-pr20672-f75300f.apk |
Attention: Patch coverage is 0%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 40.46%. Comparing base (
e87136d
) to head (f75300f
).
Files | Patch % | Lines |
---|---|---|
...s/android/ui/posts/EditorJetpackSocialViewModel.kt | 0.00% | 0 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Fixes #20662
Even though I couldn't reproduce the crash, the root cause seem to be a race condition that makes the method
EditorJetpackSocialViewModel#shouldShowJetpackSocial
be called beforeeditPostRepository
is initialized. As a quick fix to avoid crashing, I'm checking if the variable was initialized before using it.To Test:
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
--
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):