Fix empty bar chart issue

irfano commented 3 weeks ago

This fixes an issue that is introduced with https://github.com/wordpress-mobile/WordPress-Android/pull/20605. Some cards were stuck in the loading state, and the date picker was disabled.

I added values with 0f to the chart data to fix the issue.

before	after

To Test:

Log in.
Select a site with empty stats. (You can create a fresh one)
Open the DAYS tab from "My Site → Stats"

Regression Notes

Potential unintended areas of impact
- None
What I did to test those areas of impact (or what existing automated tests I relied on)
- N/A
What automated tests I added (or what prevented me from doing so)
- This reverts some part of previous PR.

PR Submission Checklist:

[x] I have completed the Regression Notes.
[x] I have considered adding accessibility improvements for my changes.
[x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

[ ] ~WordPress.com sites and self-hosted Jetpack sites.~
[ ] ~Portrait and landscape orientations.~
[ ] ~Light and dark modes.~
[ ] ~Fonts: Larger, smaller and bold text.~
[ ] ~High contrast.~
[ ] ~Talkback.~
[ ] ~Languages with large words or with letters/accents not frequently used in English.~
[ ] ~Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)~
[ ] ~Large and small screen sizes. (Tablet and smaller phones)~
[ ] ~Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)~

sonarcloud[bot] commented 3 weeks ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

wpmobilebot commented 3 weeks ago

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20674-a2e569d
	Commit	a2e569ddf51f5c395846bb6162921fdafbded3de
	Direct Download	`wordpress-prototype-build-pr20674-a2e569d.apk`

Note: Google Login is not supported on these builds.

wpmobilebot commented 3 weeks ago

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20674-a2e569d
	Commit	a2e569ddf51f5c395846bb6162921fdafbded3de
	Direct Download	`jetpack-prototype-build-pr20674-a2e569d.apk`

Note: Google Login is not supported on these builds.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 40.27%. Comparing base (921ce21) to head (a2e569d).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## trunk #20674 +/- ## =========================================== - Coverage 82.58% 40.27% -42.32% =========================================== Files 15 1476 +1461 Lines 534 68115 +67581 Branches 50 11281 +11231 =========================================== + Hits 441 27431 +26990 - Misses 75 38190 +38115 - Partials 18 2494 +2476 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

wordpress-mobile / WordPress-Android