Consolidate granular stats tabs

irfano commented 3 weeks ago

Fixes #20660

This removes codes from the old Traffic tab and consolidates granular tabs to the new TRAFFIC tab.

Additionally, reverts removing of Today card (https://github.com/wordpress-mobile/WordPress-Android/commit/8c2c169093cc5cec65aa57e26c90817fb3a440f2). We removed the Today card because we were showing a similar card in the previous project. Now it's not necessary to remove it.

To Test:

Disabled `stats_traffic_subscribers_tab` flag

Disable stats_traffic_subscribers_tab config from "Me → Debug settings"
Open "My Site → Stats".
Verify that there are INSIGHTS/DAYS/WEEKS/MONTHS/YEARS tabs and they work as before.

Enabled `stats_traffic_subscribers_tab` flag

Enable stats_traffic_subscribers_tab config from "Me → Debug settings"
Open "My Site → Stats".
Verify that there are TRAFFIC/INSIGHTS tabs and they work as expected.

Regression Notes

Potential unintended areas of impact
- Disabled and enabled states of stats_traffic_subscribers_tab
What I did to test those areas of impact (or what existing automated tests I relied on)
- Tested manually.
What automated tests I added (or what prevented me from doing so)
- Updated current tests.

PR Submission Checklist:

[x] I have completed the Regression Notes.
[x] I have considered adding accessibility improvements for my changes.
[x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

[ ] ~WordPress.com sites and self-hosted Jetpack sites.~
[ ] ~Portrait and landscape orientations.~
[ ] ~Light and dark modes.~
[ ] ~Fonts: Larger, smaller and bold text.~
[ ] ~High contrast.~
[ ] ~Talkback.~
[ ] ~Languages with large words or with letters/accents not frequently used in English.~
[ ] ~Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)~
[ ] ~Large and small screen sizes. (Tablet and smaller phones)~
[ ] ~Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)~

dangermattic commented 3 weeks ago

	2 Warnings
:warning:	`strings.xml` files should only be updated on release branches, when the translations are downloaded by our automation.
:warning:	This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by :no_entry_sign: Danger

wpmobilebot commented 3 weeks ago

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20675-6e1d6fd
	Commit	6e1d6fde3359e286e92384cc5fc266a222db91d0
	Direct Download	`jetpack-prototype-build-pr20675-6e1d6fd.apk`

Note: Google Login is not supported on these builds.

wpmobilebot commented 3 weeks ago

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20675-6e1d6fd
	Commit	6e1d6fde3359e286e92384cc5fc266a222db91d0
	Direct Download	`wordpress-prototype-build-pr20675-6e1d6fd.apk`

Note: Google Login is not supported on these builds.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.58%. Comparing base (7722b6e) to head (6e1d6fd). Report is 50 commits behind head on trunk.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## trunk #20675 +/- ## =========================================== + Coverage 40.44% 82.58% +42.13% =========================================== Files 1485 15 -1470 Lines 68475 534 -67941 Branches 11323 50 -11273 =========================================== - Hits 27695 441 -27254 + Misses 38268 75 -38193 + Partials 2512 18 -2494 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 3 weeks ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

irfano commented 3 weeks ago

I have noticed that Views & Visitors detail screen is not working on this PR. I need to make significant changes to address this issue because the Views & Visitors detail screen was relying on cached data from the WEEKS tab. I will address this in a separate PR.

aditi-bhatia commented 3 weeks ago

I have noticed that Views & Visitors detail screen is not working on this PR. I need to make significant changes to address this issue because the Views & Visitors detail screen was relying on cached data from the WEEKS tab. I will address this in a separate PR.

Sounds good, since this issue only occurs with the feature flag on, I've gone ahead and approved/merged this PR

wordpress-mobile / WordPress-Android