wordpress-mobile / WordPress-Android

WordPress for Android
http://android.wordpress.org
GNU General Public License v2.0
2.92k stars 1.3k forks source link

Update donut chart label formatting #20678

Closed aditi-bhatia closed 3 weeks ago

aditi-bhatia commented 3 weeks ago

Fixes https://github.com/wordpress-mobile/WordPress-Android/issues/19959

This PR updates the formatting for the donut chart legend. Before After
Screenshot 2024-04-18 at 3 53 07 PM Screenshot 2024-04-18 at 3 53 17 PM
Screenshot 2024-04-18 at 3 52 09 PM Screenshot 2024-04-18 at 3 52 21 PM

To Test:

  1. Navigate to Stats -> Insights -> Total Followers.
  2. Ensure that the legend is formatted well and test with different device font sizes.

Regression Notes

  1. Potential unintended areas of impact

    • None
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • None
  3. What automated tests I added (or what prevented me from doing so)

    • None

PR Submission Checklist:


Testing Checklist (strike-out the not-applying and unnecessary ones):

wpmobilebot commented 3 weeks ago
Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20678-ade6674
Commitade66749e0b8821bf0640e37ed062ea022f44013
Direct Downloadjetpack-prototype-build-pr20678-ade6674.apk
Note: Google Login is not supported on these builds.
wpmobilebot commented 3 weeks ago
WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20678-ade6674
Commitade66749e0b8821bf0640e37ed062ea022f44013
Direct Downloadwordpress-prototype-build-pr20678-ade6674.apk
Note: Google Login is not supported on these builds.
sonarcloud[bot] commented 3 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 40.30%. Comparing base (2f077fa) to head (ade6674). Report is 94 commits behind head on trunk.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## trunk #20678 +/- ## ========================================== - Coverage 40.46% 40.30% -0.16% ========================================== Files 1484 1478 -6 Lines 68413 68235 -178 Branches 11307 11299 -8 ========================================== - Hits 27683 27505 -178 Misses 38230 38230 Partials 2500 2500 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.