Fix null `siteModel` crash on the posts list screen

irfano commented 3 weeks ago

Fixes #20534

This aims to address a crash that started 5 years ago and was previously attempted to be fixed (with https://github.com/wordpress-mobile/WordPress-Android/pull/13171).

I couldn't reproduce the crash, but I'm implementing the suggestion made in https://github.com/wordpress-mobile/WordPress-Android/pull/13171#issuecomment-712938324.

Using PendingIntent.FLAG_ONE_SHOT and PendingIntent.FLAG_UPDATE_CURRENT together may not work properly, so I believe this change will resolve the crash.

To Test:

I don't know how to reproduce this issue but you can test starting posts list from the notification.

Ensure notification permission is allowed.
Add a video to a post.
Publish and put the app into the background just after publishing the post.
Verify that you received a "post published" notification and that it opens the posts list.

test notification video

https://github.com/wordpress-mobile/WordPress-Android/assets/2471769/176a97ef-f14f-4c29-84d2-549b48fae486

Regression Notes

Potential unintended areas of impact
- "post published" notification
What I did to test those areas of impact (or what existing automated tests I relied on)
- Tested manually.
What automated tests I added (or what prevented me from doing so)
- Since I couldn't reproduce the crash, adding automated tests is not proper.

PR Submission Checklist:

[x] I have completed the Regression Notes.
[x] I have considered adding accessibility improvements for my changes.
[x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

[ ] ~WordPress.com sites and self-hosted Jetpack sites.~
[ ] ~Portrait and landscape orientations.~
[ ] ~Light and dark modes.~
[ ] ~Fonts: Larger, smaller and bold text.~
[ ] ~High contrast.~
[ ] ~Talkback.~
[ ] ~Languages with large words or with letters/accents not frequently used in English.~
[ ] ~Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)~
[ ] ~Large and small screen sizes. (Tablet and smaller phones)~
[ ] ~Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)~

sonarcloud[bot] commented 3 weeks ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

wpmobilebot commented 3 weeks ago

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20683-96d3a69
	Commit	96d3a6935d89432b0f9f6a17369cf861e2980bad
	Direct Download	`jetpack-prototype-build-pr20683-96d3a69.apk`

Note: Google Login is not supported on these builds.

wpmobilebot commented 3 weeks ago

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20683-96d3a69
	Commit	96d3a6935d89432b0f9f6a17369cf861e2980bad
	Direct Download	`wordpress-prototype-build-pr20683-96d3a69.apk`

Note: Google Login is not supported on these builds.

wordpress-mobile / WordPress-Android