Closed aditi-bhatia closed 3 weeks ago
2 Warnings | |
---|---|
:warning: | strings.xml files should only be updated on release branches, when the translations are downloaded by our automation. |
:warning: | PR is not assigned to a milestone. |
Generated by :no_entry_sign: Danger
App Name | WordPress | |
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr20685-2112f8f | |
Commit | 2112f8f75c13f9de90e4b54dfed22f7ffc92aec2 | |
Direct Download | wordpress-prototype-build-pr20685-2112f8f.apk |
App Name | Jetpack | |
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr20685-2112f8f | |
Commit | 2112f8f75c13f9de90e4b54dfed22f7ffc92aec2 | |
Direct Download | jetpack-prototype-build-pr20685-2112f8f.apk |
Attention: Patch coverage is 10.52632%
with 17 lines
in your changes are missing coverage. Please review.
Project coverage is 40.62%. Comparing base (
ed25d7d
) to head (2112f8f
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Issues
1 New issue
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
I'm merging but I want to remind you that you can complete the "Regression Notes", "PR Submission Checklist" and "Testing Checklist" sections after the merge, @aditi-bhatia.
Thank you for the reminder! I've gone ahead and updated those sections.
Fixes https://github.com/wordpress-mobile/WordPress-Android/issues/20680
This PR adds in some basic groundwork for the new Subscribers tab, which is feature flagged behind
stats_traffic_subscribers_tab
. It is currently usingmapInsights
fromUiModelMapper.kt
as a placeholder for now, which is why you will see the screen below:I've left the uses cases empty for now as that work can be done in a separate PR.
To Test:
stats_traffic_subscribers_tab
feature flag on, ensure you see theSubscribers
tab as it appears in the screenshot above.Subscribers
tab should fire thestats_subscribers_accessed
tracked event.stats_traffic_subscribers_tab
feature flag off, ensure you don't see theSubscribers
tab and theweeks/days/months
tabs appear as expected.Regression Notes
Potential unintended areas of impact
stats_traffic_subscribers_tab
feature flagWhat I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):