wordpress-mobile / WordPress-Android

WordPress for Android
http://android.wordpress.org
GNU General Public License v2.0
2.92k stars 1.3k forks source link

[Reader] Implement tags feed UI #20686

Closed RenanLukas closed 3 weeks ago

RenanLukas commented 3 weeks ago

Fixes #20623

Light theme

https://github.com/wordpress-mobile/WordPress-Android/assets/14964993/0dd6522c-9489-40ca-9e09-087616398444

Dark theme

https://github.com/wordpress-mobile/WordPress-Android/assets/14964993/6508d274-d21a-4cea-b2ba-f1e9c375af0d


To Test:

The UI component is not being used yet, so in order to test it you can run ReaderTagsFeedLoaded and ReaderTagsFeedLoading previews and compare them with Figma specs.


Regression Notes

  1. Potential unintended areas of impact

    • None
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Manual testing
  3. What automated tests I added (or what prevented me from doing so)

    --


PR Submission Checklist:


Testing Checklist (strike-out the not-applying and unnecessary ones):

dangermattic commented 3 weeks ago
5 Warnings
:warning: strings.xml files should only be updated on release branches, when the translations are downloaded by our automation.
:warning: This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
:warning: Class UiState is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class Loaded is missing tests, but unit-tests-exemption label was set to ignore this.
:warning: Class TagsFeedPostItem is missing tests, but unit-tests-exemption label was set to ignore this.

Generated by :no_entry_sign: Danger

wpmobilebot commented 3 weeks ago
WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20686-1bab9d1
Commit1bab9d10db2e2cf09a4a32784bdc3c8e07292560
Direct Downloadwordpress-prototype-build-pr20686-1bab9d1.apk
Note: Google Login is not supported on these builds.
wpmobilebot commented 3 weeks ago
Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20686-1bab9d1
Commit1bab9d10db2e2cf09a4a32784bdc3c8e07292560
Direct Downloadjetpack-prototype-build-pr20686-1bab9d1.apk
Note: Google Login is not supported on these builds.
codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 40.33%. Comparing base (c54757c) to head (1bab9d1). Report is 7 commits behind head on feature/tags-ia.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## feature/tags-ia #20686 +/- ## =================================================== + Coverage 40.15% 40.33% +0.17% =================================================== Files 1465 1474 +9 Lines 67522 67878 +356 Branches 11183 11225 +42 =================================================== + Hits 27114 27377 +263 - Misses 37959 38034 +75 - Partials 2449 2467 +18 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 3 weeks ago

Quality Gate Failed Quality Gate failed

Failed conditions
11.5% Duplication on New Code (required ≤ 10%)

See analysis details on SonarCloud