Closed RenanLukas closed 3 weeks ago
5 Warnings | |
---|---|
:warning: | strings.xml files should only be updated on release branches, when the translations are downloaded by our automation. |
:warning: | This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews. |
:warning: | Class UiState is missing tests, but unit-tests-exemption label was set to ignore this. |
:warning: | Class Loaded is missing tests, but unit-tests-exemption label was set to ignore this. |
:warning: | Class TagsFeedPostItem is missing tests, but unit-tests-exemption label was set to ignore this. |
Generated by :no_entry_sign: Danger
App Name | WordPress | |
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr20686-1bab9d1 | |
Commit | 1bab9d10db2e2cf09a4a32784bdc3c8e07292560 | |
Direct Download | wordpress-prototype-build-pr20686-1bab9d1.apk |
App Name | Jetpack | |
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr20686-1bab9d1 | |
Commit | 1bab9d10db2e2cf09a4a32784bdc3c8e07292560 | |
Direct Download | jetpack-prototype-build-pr20686-1bab9d1.apk |
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 40.33%. Comparing base (
c54757c
) to head (1bab9d1
). Report is 7 commits behind head on feature/tags-ia.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Failed conditions
11.5% Duplication on New Code (required ≤ 10%)
Fixes #20623
Light theme
https://github.com/wordpress-mobile/WordPress-Android/assets/14964993/0dd6522c-9489-40ca-9e09-087616398444
Dark theme
https://github.com/wordpress-mobile/WordPress-Android/assets/14964993/6508d274-d21a-4cea-b2ba-f1e9c375af0d
To Test:
The UI component is not being used yet, so in order to test it you can run
ReaderTagsFeedLoaded
andReaderTagsFeedLoading
previews and compare them with Figma specs.Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
--
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):