Replace tab with a popup window in notifications

jarvislin commented 3 weeks ago

See pcdRpT-5aB-p2

Light	Dark

To Test:

Sign in the JP app
Switch to the Notifications tab
Click on the title in the Toolbar
It should display a popup window
Click on the menu options
The popup should be dismissed, and then switch to the filter category you clicked, the title should be updated.
Rotate your screen
The title and filter category should be correct after the rotation.
Done! Thank you!

Know issue The shadow of the popup window is not clear in dark mode.

Regression Notes

Potential unintended areas of impact
- notifications
What I did to test those areas of impact (or what existing automated tests I relied on)
- manual
What automated tests I added (or what prevented me from doing so)
- none

PR Submission Checklist:

[x] I have completed the Regression Notes.
[x] I have considered adding accessibility improvements for my changes.
[x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

[ ] WordPress.com sites and self-hosted Jetpack sites.
[x] Portrait and landscape orientations.
[x] Light and dark modes.
[ ] Fonts: Larger, smaller and bold text.
[ ] High contrast.
[ ] Talkback.
[ ] Languages with large words or with letters/accents not frequently used in English.
[ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
[ ] Large and small screen sizes. (Tablet and smaller phones)
[ ] Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

dangermattic commented 3 weeks ago

	1 Warning
:warning:	`strings.xml` files should only be updated on release branches, when the translations are downloaded by our automation.

Generated by :no_entry_sign: Danger

wpmobilebot commented 3 weeks ago

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20693-c6d3c0e
	Commit	c6d3c0e0a7fcd677663f4beef80c36475f203013
	Direct Download	`jetpack-prototype-build-pr20693-c6d3c0e.apk`

Note: Google Login is not supported on these builds.

wpmobilebot commented 3 weeks ago

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20693-c6d3c0e
	Commit	c6d3c0e0a7fcd677663f4beef80c36475f203013
	Direct Download	`wordpress-prototype-build-pr20693-c6d3c0e.apk`

Note: Google Login is not supported on these builds.

sonarcloud[bot] commented 3 weeks ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

jarvislin commented 3 weeks ago

This can be part of a follow up PR: Wdyt of reusing the colour scheme from the reader (JetpackDropdownMenu) to make the boundaries of the pop up more clear?

I think the color in your screenshot is more suitable, I'll update the color in a follow-up PR, thanks for the review and suggestion!

wordpress-mobile / WordPress-Android