wordpress-mobile / WordPress-Android

WordPress for Android
http://android.wordpress.org
GNU General Public License v2.0
2.92k stars 1.3k forks source link

[Reader] Implement "Tags" feed empty state UI #20695

Closed RenanLukas closed 3 weeks ago

RenanLukas commented 3 weeks ago

[!WARNING]
Should be merged after https://github.com/wordpress-mobile/WordPress-Android/pull/20686

Fixes #20584

Screenshot 2024-04-22 at 5 01 20 PM Screenshot 2024-04-22 at 5 01 38 PM


To Test:

The UI component is not being used yet, so in order to test it you can run ReaderTagsFeedEmpty preview and compare it with the existing Discover feed empty state:

image

Regression Notes

  1. Potential unintended areas of impact

    • None
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Manual testing
  3. What automated tests I added (or what prevented me from doing so)

    --


PR Submission Checklist:


Testing Checklist (strike-out the not-applying and unnecessary ones):

dangermattic commented 3 weeks ago
1 Warning
:warning: Class Empty is missing tests, but unit-tests-exemption label was set to ignore this.

Generated by :no_entry_sign: Danger

wpmobilebot commented 3 weeks ago
Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20695-101e25e
Commit101e25ed3929e349599ae19799cf80eb7cba3074
Direct Downloadjetpack-prototype-build-pr20695-101e25e.apk
Note: Google Login is not supported on these builds.
wpmobilebot commented 3 weeks ago
WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20695-101e25e
Commit101e25ed3929e349599ae19799cf80eb7cba3074
Direct Downloadwordpress-prototype-build-pr20695-101e25e.apk
Note: Google Login is not supported on these builds.
sonarcloud[bot] commented 3 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.58%. Comparing base (1bab9d1) to head (101e25e). Report is 8 commits behind head on feature/tags-ia.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## feature/tags-ia #20695 +/- ## ==================================================== + Coverage 40.33% 82.58% +42.25% ==================================================== Files 1474 15 -1459 Lines 67878 534 -67344 Branches 11225 50 -11175 ==================================================== - Hits 27377 441 -26936 + Misses 38034 75 -37959 + Partials 2467 18 -2449 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.