Notifications Refresh (Phase 2)

antonis commented 3 weeks ago

Subtasks

Notifications List

To Test:

Each issue listed above should be tested individually

Regression Notes

Potential unintended areas of impact
- N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
- N/A
What automated tests I added (or what prevented me from doing so)
- N/A

PR Submission Checklist:

[ ] I have completed the Regression Notes.
[ ] I have considered adding accessibility improvements for my changes.
[ ] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

[ ] WordPress.com sites and self-hosted Jetpack sites.
[ ] Portrait and landscape orientations.
[ ] Light and dark modes.
[ ] Fonts: Larger, smaller and bold text.
[ ] High contrast.
[ ] Talkback.
[ ] Languages with large words or with letters/accents not frequently used in English.
[ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
[ ] Large and small screen sizes. (Tablet and smaller phones)
[ ] Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

dangermattic commented 3 weeks ago

	1 Error
:no_entry_sign:	This PR is tagged with `Do Not Merge` label(s).

	3 Warnings
:warning:	`strings.xml` files should only be updated on release branches, when the translations are downloaded by our automation.
:warning:	This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
:warning:	Class `BlockType` is missing tests, but `unit-tests-exemption` label was set to ignore this.

Generated by :no_entry_sign: Danger

wpmobilebot commented 3 weeks ago

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20697-d8edd7a
	Commit	d8edd7a498ebe16a8628df42d3855c051495567f
	Direct Download	`jetpack-prototype-build-pr20697-d8edd7a.apk`

Note: Google Login is not supported on these builds.

wpmobilebot commented 3 weeks ago

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20697-d8edd7a
	Commit	d8edd7a498ebe16a8628df42d3855c051495567f
	Direct Download	`wordpress-prototype-build-pr20697-d8edd7a.apk`

Note: Google Login is not supported on these builds.

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 8.63971% with 497 lines in your changes are missing coverage. Please review.

Project coverage is 40.72%. Comparing base (8e84068) to head (d8edd7a). Report is 12 commits behind head on trunk.

Files	Patch %	Lines
...id/ui/notifications/blocks/CommentUserNoteBlock.kt	0.00%	124 Missing :warning:
...press/android/ui/notifications/blocks/NoteBlock.kt	4.42%	108 Missing :warning:
...s/android/ui/notifications/blocks/UserNoteBlock.kt	0.00%	79 Missing :warning:
...android/ui/notifications/blocks/HeaderNoteBlock.kt	17.64%	54 Missing and 2 partials :warning:
.../ui/notifications/blocks/NoteBlockClickableSpan.kt	0.00%	51 Missing :warning:
...android/ui/notifications/blocks/FooterNoteBlock.kt	0.00%	35 Missing :warning:
...otifications/blocks/NoteBlockLinkMovementMethod.kt	0.00%	27 Missing :warning:
...press/android/ui/notifications/blocks/BlockType.kt	0.00%	15 Missing :warning:
...roid/ui/notifications/blocks/GeneratedNoteBlock.kt	0.00%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## trunk #20697 +/- ## ========================================== + Coverage 40.66% 40.72% +0.05% ========================================== Files 1490 1490 Lines 68621 68612 -9 Branches 11338 11364 +26 ========================================== + Hits 27907 27942 +35 + Misses 38195 38151 -44 Partials 2519 2519 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.