Fix IllegalStateException by using postValue() in clearMenuStep()

AjeshRPai commented 3 weeks ago

(cherry picked from commit f980e0dd4f6b685a8fe0c09cb248b7276ce90473)

Fixes

Merges the changes in this https://github.com/wordpress-mobile/WordPress-Android/pull/20654 to the trunk as the issue is surging in 24.7

Regression Notes

Potential unintended areas of impact Crash is still happening
What I did to test those areas of impact (or what existing automated tests I relied on) Manual testing
What automated tests I added (or what prevented me from doing so) NA

PR submission checklist:

[x] I have completed the Regression Notes.
[x] I have considered adding accessibility improvements for my changes.
[x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

[x] Portrait and landscape orientations.
[x] Light and dark modes.
[x] Fonts: Larger, smaller and bold text.
[x] High contrast.
[x] Talkback.
[x] Languages with large words or with letters/accents not frequently used in English.
[x] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
[x] Large and small screen sizes. (Tablet and smaller phones)
[x] Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

dangermattic commented 3 weeks ago

	1 Warning
:warning:	This PR is assigned to the milestone 24.7 ❄️. The due date for this milestone has already passed. Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by :no_entry_sign: Danger

sonarcloud[bot] commented 3 weeks ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

AjeshRPai commented 3 weeks ago

cc: @oguzkocer Letting you know about this PR, targeting next beta

wpmobilebot commented 3 weeks ago

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20699-96b9799
	Commit	96b97993f029424ccef39815536cba018a9cc473
	Direct Download	`wordpress-prototype-build-pr20699-96b9799.apk`

Note: Google Login is not supported on these builds.

wpmobilebot commented 3 weeks ago

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20699-96b9799
	Commit	96b97993f029424ccef39815536cba018a9cc473
	Direct Download	`jetpack-prototype-build-pr20699-96b9799.apk`

Note: Google Login is not supported on these builds.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 40.46%. Comparing base (2aa491b) to head (96b9799).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## release/24.7 #20699 +/- ## ============================================= Coverage 40.46% 40.46% ============================================= Files 1484 1484 Lines 68417 68417 Branches 11308 11308 ============================================= Hits 27682 27682 Misses 38233 38233 Partials 2502 2502 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

wordpress-mobile / WordPress-Android