wordpress-mobile / WordPress-Android

WordPress for Android
http://android.wordpress.org
GNU General Public License v2.0
2.92k stars 1.3k forks source link

Update the UI of header and list in Likes Details #20700

Closed jarvislin closed 2 weeks ago

jarvislin commented 3 weeks ago

See yWt5gg3nWORhu079Qfv3mS-fi-1135%3A2576

This is a UI redesign in Likes Details. The change scope includes:

  1. Header
  2. List item
Post Likes Comment Likes
Screenshot_20240424-110025 Screenshot_20240424-110051

To Test:

  1. Sign in the JP app
  2. Switch to the tab of Notifications
  3. Find a Post Like notification and click it
  4. The header and list should be the same as the design (without avatar on the header)
  5. Click on the header and the list item, it should keep the original behavior
  6. Back to Notifications
  7. Find a Comment Like notification and click it
  8. The header and list should be the same as the design (with avatar on the header)
  9. Click on the header and the list item, it should keep the original behavior
  10. Done, thank you!

Known issue The comment view reuses the header, it displays incorrectly at the moment. I'll fix it when I develop the task of 🤖 Comment Details: Header redesign


Regression Notes

  1. Potential unintended areas of impact

    • notifications
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • manual
  3. What automated tests I added (or what prevented me from doing so)

    • none

PR Submission Checklist:


Testing Checklist (strike-out the not-applying and unnecessary ones):

wpmobilebot commented 3 weeks ago
WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20700-a127468
Commita127468eafec08f6c80f2661c58668032c83cc97
Direct Downloadwordpress-prototype-build-pr20700-a127468.apk
Note: Google Login is not supported on these builds.
wpmobilebot commented 3 weeks ago
Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20700-a127468
Commita127468eafec08f6c80f2661c58668032c83cc97
Direct Downloadjetpack-prototype-build-pr20700-a127468.apk
Note: Google Login is not supported on these builds.
sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud