Closed pantstamp closed 3 weeks ago
App Name | Jetpack | |
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr20702-f005745 | |
Commit | f005745806a203334a555cd6b85cf82e215a9a81 | |
Direct Download | jetpack-prototype-build-pr20702-f005745.apk |
App Name | WordPress | |
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr20702-f005745 | |
Commit | f005745806a203334a555cd6b85cf82e215a9a81 | |
Direct Download | wordpress-prototype-build-pr20702-f005745.apk |
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 82.58%. Comparing base (
2aa491b
) to head (f005745
). Report is 2 commits behind head on release/24.7.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Fixes https://github.com/wordpress-mobile/WordPress-Android/issues/20667
There are instances in which the Edit Post view is not visible on return from background. The issue is hard to replicate and to date, have had a single developer able to reproduce this. As such, it's been difficult to find a fix.
This PR updates EditPostActivity.retrieveSavedInstanceState to use
supportFragmentManager
instead offragmentManager
while retrieving the EditorFragmentAbstract from the savedInstanceState bundle.There is another change that I am contemplating, switching from
FragmentPagerAdapter
toFragmentStatePagerAdapter
; however lifecycle management is a little different and I don't want to risk introducing other issues without fully thinking it through. I had switched it in the branch, but removed the change with the submitted PR.To Test:
Regression Notes
Potential unintended areas of impact Edit post doesn't return from background correctly
What I did to test those areas of impact (or what existing automated tests I relied on) N/A
What automated tests I added (or what prevented me from doing so) N/A
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist (strike-out the not-applying and unnecessary ones): N/A