Fixes unknown color Aztec crash

antonis commented 3 weeks ago

Fixes #20694 and #20698

Depends on: https://github.com/wordpress-mobile/AztecEditor-Android/pull/1079

Handles unknown color values in Aztec

To Test:

See https://github.com/wordpress-mobile/AztecEditor-Android/pull/1079#pullrequestreview-2017543845

Regression Notes

Potential unintended areas of impact
- Editor
What I did to test those areas of impact (or what existing automated tests I relied on)
- Manual testing
What automated tests I added (or what prevented me from doing so)
- N/A

PR Submission Checklist:

[ ] I have completed the Regression Notes.
[ ] I have considered adding accessibility improvements for my changes.
[ ] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

[ ] WordPress.com sites and self-hosted Jetpack sites.
[ ] Portrait and landscape orientations.
[ ] Light and dark modes.
[ ] Fonts: Larger, smaller and bold text.
[ ] High contrast.
[ ] Talkback.
[ ] Languages with large words or with letters/accents not frequently used in English.
[ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
[ ] Large and small screen sizes. (Tablet and smaller phones)
[ ] Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

dangermattic commented 3 weeks ago

	1 Warning
:warning:	This PR is assigned to the milestone 24.7 ❄️. The due date for this milestone has already passed. Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by :no_entry_sign: Danger

wpmobilebot commented 3 weeks ago

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20704-aed78e7
	Commit	aed78e7467b31d15e8c6d99cf8d42bfd0e9c8220
	Direct Download	`jetpack-prototype-build-pr20704-aed78e7.apk`

Note: Google Login is not supported on these builds.

wpmobilebot commented 3 weeks ago

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20704-aed78e7
	Commit	aed78e7467b31d15e8c6d99cf8d42bfd0e9c8220
	Direct Download	`wordpress-prototype-build-pr20704-aed78e7.apk`

Note: Google Login is not supported on these builds.

sonarcloud[bot] commented 3 weeks ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

wpmobilebot commented 3 weeks ago

Found 1 violations:

The PR caused some dependency changes (expand to see details)

```diff \--- project :libs:editor - +--- org.wordpress:aztec:{strictly v2.1.1} -> v2.1.1 + +--- org.wordpress:aztec:{strictly v2.1.2} -> v2.1.2 - +--- org.wordpress.aztec:wordpress-shortcodes:{strictly v2.1.1} -> v2.1.1 - | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*) - | +--- org.wordpress:aztec:v2.1.1 (*) - | \--- androidx.appcompat:appcompat:1.0.0 -> 1.6.1 (*) + +--- org.wordpress.aztec:wordpress-shortcodes:{strictly v2.1.2} -> v2.1.2 + | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*) + | +--- org.wordpress:aztec:v2.1.2 (*) + | \--- androidx.appcompat:appcompat:1.0.0 -> 1.6.1 (*) - +--- org.wordpress.aztec:wordpress-comments:{strictly v2.1.1} -> v2.1.1 - | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*) - | +--- org.wordpress:aztec:v2.1.1 (*) - | +--- androidx.legacy:legacy-support-v4:1.0.0 (*) - | \--- com.google.android.material:material:1.0.0 -> 1.9.0 (*) + +--- org.wordpress.aztec:wordpress-comments:{strictly v2.1.2} -> v2.1.2 + | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*) + | +--- org.wordpress:aztec:v2.1.2 (*) + | +--- androidx.legacy:legacy-support-v4:1.0.0 (*) + | \--- com.google.android.material:material:1.0.0 -> 1.9.0 (*) \--- org.wordpress.gutenberg-mobile:react-native-gutenberg-bridge:v1.117.0 \--- org.wordpress.gutenberg-mobile:react-native-aztec:v1.117.0 - +--- org.wordpress:aztec:v2.1.1 (*) + +--- org.wordpress:aztec:v2.1.1 -> v2.1.2 (*) - +--- org.wordpress.aztec:wordpress-shortcodes:v2.1.1 (*) + +--- org.wordpress.aztec:wordpress-shortcodes:v2.1.1 -> v2.1.2 (*) - +--- org.wordpress.aztec:wordpress-comments:v2.1.1 (*) + +--- org.wordpress.aztec:wordpress-comments:v2.1.1 -> v2.1.2 (*) \--- org.wordpress.aztec:glide-loader:v2.1.1 - \--- org.wordpress:aztec:v2.1.1 (*) + \--- org.wordpress:aztec:v2.1.1 -> v2.1.2 (*) ```

Please review and act accordingly

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.58%. Comparing base (936ab4a) to head (aed78e7).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## release/24.7 #20704 +/- ## ================================================= + Coverage 40.46% 82.58% +42.12% ================================================= Files 1484 15 -1469 Lines 68417 534 -67883 Branches 11308 50 -11258 ================================================= - Hits 27682 441 -27241 + Misses 38233 75 -38158 + Partials 2502 18 -2484 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

wordpress-mobile / WordPress-Android