wordpress-mobile / WordPress-Android

WordPress for Android
http://android.wordpress.org
GNU General Public License v2.0
2.92k stars 1.3k forks source link

Add a Share Post button in Likes Details #20709

Closed jarvislin closed 3 weeks ago

jarvislin commented 3 weeks ago

See the design on Figma yWt5gg3nWORhu079Qfv3mS-fi-1135%3A2576 Blocked by #20700

This is a UI redesign in Likes Details. We add a button in Likes Details for sharing the post link.

Dark Light
Screenshot_20240424-133033 Screenshot_20240424-133018

To Test:

  1. Sign in the JP app
  2. Switch to the tab of Notifications
  3. Find a Post Like notification and click it
  4. There should be a Share your post button at the bottom of screen
  5. Click on the button, it should be able to share the link of that post to other apps.
  6. Back to Notifications
  7. Find a Comment Like notification and click it
  8. There should not be the share button at the bottom of screen
  9. Done, thank you!

Regression Notes

  1. Potential unintended areas of impact

    • notifications
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • manual
  3. What automated tests I added (or what prevented me from doing so)

    • updated an out-dated unit test

PR Submission Checklist:


Testing Checklist (strike-out the not-applying and unnecessary ones):

dangermattic commented 3 weeks ago
1 Warning
:warning: strings.xml files should only be updated on release branches, when the translations are downloaded by our automation.

Generated by :no_entry_sign: Danger

wpmobilebot commented 3 weeks ago
Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20709-53819d1
Commit53819d187deee0d494c16ebff636e12d6036096d
Direct Downloadjetpack-prototype-build-pr20709-53819d1.apk
Note: Google Login is not supported on these builds.
wpmobilebot commented 3 weeks ago
WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20709-53819d1
Commit53819d187deee0d494c16ebff636e12d6036096d
Direct Downloadwordpress-prototype-build-pr20709-53819d1.apk
Note: Google Login is not supported on these builds.
sonarcloud[bot] commented 3 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 40.64%. Comparing base (28557c1) to head (53819d1). Report is 20 commits behind head on feature/notifications_refresh_p2.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## feature/notifications_refresh_p2 #20709 +/- ## ================================================================= Coverage 40.63% 40.64% ================================================================= Files 1485 1485 Lines 68281 68289 +8 Branches 11295 11295 ================================================================= + Hits 27746 27755 +9 + Misses 38022 38021 -1 Partials 2513 2513 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.