[Notifications Refresh] 🤖 Milestone Details: hides the title for achievements

antonis commented 2 weeks ago

This PR covers just item 1 of https://github.com/Automattic/wordpress-mobile/issues/23 and introduces a new mechanism for identifying achievement/milestone notifications (ref p1714062709630809/1714052620.609979-slack-C06BWNSR02K). The rest of the items will be covered in follow up PRs after refactoring part of the code.

To Test:

Open a milstone notifications
Verify that no title is shown

Regression Notes

Potential unintended areas of impact
- Milestone notifications
What I did to test those areas of impact (or what existing automated tests I relied on)
- Manual testing
What automated tests I added (or what prevented me from doing so)
- Added unit tests

PR Submission Checklist:

[ ] I have completed the Regression Notes.
[ ] I have considered adding accessibility improvements for my changes.
[ ] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

[ ] WordPress.com sites and self-hosted Jetpack sites.
[ ] Portrait and landscape orientations.
[ ] Light and dark modes.
[ ] Fonts: Larger, smaller and bold text.
[ ] High contrast.
[ ] Talkback.
[ ] Languages with large words or with letters/accents not frequently used in English.
[ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
[ ] Large and small screen sizes. (Tablet and smaller phones)
[ ] Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

wpmobilebot commented 2 weeks ago

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20715-9b612b3
	Commit	9b612b39b0c4df34b1a22a54f31f8f86aab7d1e4
	Direct Download	`jetpack-prototype-build-pr20715-9b612b3.apk`

Note: Google Login is not supported on these builds.

wpmobilebot commented 2 weeks ago

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20715-9b612b3
	Commit	9b612b39b0c4df34b1a22a54f31f8f86aab7d1e4
	Direct Download	`wordpress-prototype-build-pr20715-9b612b3.apk`

Note: Google Login is not supported on these builds.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 40.70%. Comparing base (8548a93) to head (9b612b3).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## feature/notifications_refresh_p2 #20715 +/- ## ==================================================================== + Coverage 40.68% 40.70% +0.01% ==================================================================== Files 1490 1490 Lines 68551 68573 +22 Branches 11359 11359 ==================================================================== + Hits 27891 27913 +22 Misses 38142 38142 Partials 2518 2518 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.