Fixes: NullPointerException in BlazeViewModel

pantstamp commented 2 weeks ago

Fixes #20644 This PR tries to fix the NullPointerException that is described on the above ticket.

To Test:

Enable Developer options on your device
Go to Developer Options → Background Process limit → Set 1 as background process limit
Install a build from the trunk
Go to Pages screen
Pick a page and tap on the menu button (three dots menu)
Tap on "Promote with Blaze"
Wait for the blaze screen to load
Move the app to background and use 2+ other apps
Launch the app from app launcher
Verify that you see the crash in your LogCat

FATAL EXCEPTION: main Process: com.jetpack.android.prealpha, PID: 17395 java.lang.RuntimeException: Unable to start activity ComponentInfo{com.jetpack.android.prealpha/org.wordpress.android.ui.blaze.blazepromote.BlazePromoteParentActivity}: java.lang.NullPointerException at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3822) at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3963) at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:103) at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:139) at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:96) at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2468) at android.os.Handler.dispatchMessage(Handler.java:106) at android.os.Looper.loopOnce(Looper.java:205) at android.os.Looper.loop(Looper.java:294) at android.app.ActivityThread.main(ActivityThread.java:8248) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:552) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:971)

Check out this PR's branch
Follow again steps 4-9
Verify that you don't see the crash in your LogCat and you end up in the pages list screen

Regression Notes

Potential unintended areas of impact
- N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
- N/A
What automated tests I added (or what prevented me from doing so)
- Relied on existing tests

PR Submission Checklist:

[x] I have completed the Regression Notes.
[x] I have considered adding accessibility improvements for my changes.
[x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

[ ] WordPress.com sites and self-hosted Jetpack sites.
[ ] Portrait and landscape orientations.
[ ] Light and dark modes.
[ ] Fonts: Larger, smaller and bold text.
[ ] High contrast.
[ ] Talkback.
[ ] Languages with large words or with letters/accents not frequently used in English.
[ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
[ ] Large and small screen sizes. (Tablet and smaller phones)
[ ] Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

dangermattic commented 2 weeks ago

	1 Warning
:warning:	This PR is assigned to the milestone 24.8. This milestone is due in less than 4 days. Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by :no_entry_sign: Danger

wpmobilebot commented 2 weeks ago

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20716-dbffad1
	Commit	dbffad1b425b179ebbe719787ea22a141f9f149a
	Direct Download	`jetpack-prototype-build-pr20716-dbffad1.apk`

Note: Google Login is not supported on these builds.

wpmobilebot commented 2 weeks ago

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20716-dbffad1
	Commit	dbffad1b425b179ebbe719787ea22a141f9f149a
	Direct Download	`wordpress-prototype-build-pr20716-dbffad1.apk`

Note: Google Login is not supported on these builds.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 90.90909% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 40.63%. Comparing base (5efa916) to head (dbffad1).

Files	Patch %	Lines
...ss/android/ui/blaze/blazeoverlay/BlazeViewModel.kt	90.90%	0 Missing and 1 partial :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## trunk #20716 +/- ## ======================================= Coverage 40.62% 40.63% ======================================= Files 1485 1485 Lines 68330 68336 +6 Branches 11302 11304 +2 ======================================= + Hits 27760 27765 +5 Misses 38054 38054 - Partials 2516 2517 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.