Refactors NoteBlock to Kotlin Part 2

antonis commented 2 weeks ago

Description

This is a follow up to https://github.com/wordpress-mobile/WordPress-Android/pull/20711

To Test:

Open the Notifications tab
Browse to different types of notifications
Verify no change in the functionality

Regression Notes

Potential unintended areas of impact
- Notifications
What I did to test those areas of impact (or what existing automated tests I relied on)
- Manual Testing
What automated tests I added (or what prevented me from doing so)
- I plan to add tests with a follow up PR

PR Submission Checklist:

[ ] I have completed the Regression Notes.
[ ] I have considered adding accessibility improvements for my changes.
[ ] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

[ ] WordPress.com sites and self-hosted Jetpack sites.
[ ] Portrait and landscape orientations.
[ ] Light and dark modes.
[ ] Fonts: Larger, smaller and bold text.
[ ] High contrast.
[ ] Talkback.
[ ] Languages with large words or with letters/accents not frequently used in English.
[ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
[ ] Large and small screen sizes. (Tablet and smaller phones)
[ ] Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

dangermattic commented 2 weeks ago

	1 Warning
:warning:	This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by :no_entry_sign: Danger

wpmobilebot commented 2 weeks ago

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20718-ab909b2
	Commit	ab909b217f53d2ad1d09bc3c4a3ac8f503821e30
	Direct Download	`jetpack-prototype-build-pr20718-ab909b2.apk`

Note: Google Login is not supported on these builds.

wpmobilebot commented 2 weeks ago

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20718-ab909b2
	Commit	ab909b217f53d2ad1d09bc3c4a3ac8f503821e30
	Direct Download	`wordpress-prototype-build-pr20718-ab909b2.apk`

Note: Google Login is not supported on these builds.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 3.92157% with 294 lines in your changes are missing coverage. Please review.

Project coverage is 40.66%. Comparing base (f476a2f) to head (71c80da).

:exclamation: Current head 71c80da differs from pull request most recent head ab909b2. Consider uploading reports for the commit ab909b2 to get more accurate results

Files	Patch %	Lines
...id/ui/notifications/blocks/CommentUserNoteBlock.kt	0.00%	124 Missing :warning:
...s/android/ui/notifications/blocks/UserNoteBlock.kt	0.00%	79 Missing :warning:
...android/ui/notifications/blocks/HeaderNoteBlock.kt	17.64%	54 Missing and 2 partials :warning:
...android/ui/notifications/blocks/FooterNoteBlock.kt	0.00%	35 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## feature/notifications_refresh_p2 #20718 +/- ## ===================================================================== - Coverage 82.58% 40.66% -41.92% ===================================================================== Files 15 1485 +1470 Lines 534 68308 +67774 Branches 50 11331 +11281 ===================================================================== + Hits 441 27778 +27337 - Misses 75 38013 +37938 - Partials 18 2517 +2499 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.