wordpress-mobile / WordPress-Android

WordPress for Android
http://android.wordpress.org
GNU General Public License v2.0
2.92k stars 1.3k forks source link

Fix #20721: Guard against null site, account, site.email and account.avatarUrl values #20724

Closed maxme closed 2 weeks ago

maxme commented 2 weeks ago

Fixes #20721

Guard against null site, account, site.email and account.avatarUrl values

Regression Notes

  1. Potential unintended areas of impact

    • This is very limited change
    • Returns an empty string as the avatar URL in case of an unexpected input, this will result in showing the avatar default (fallback image).
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • No test
  3. What automated tests I added (or what prevented me from doing so)

    • No automated tests

PR Submission Checklist:


Testing Checklist (strike-out the not-applying and unnecessary ones):

~- [ ] WordPress.com sites and self-hosted Jetpack sites.~ ~- [ ] Portrait and landscape orientations.~ ~- [ ] Light and dark modes.~ ~- [ ] Fonts: Larger, smaller and bold text.~ ~- [ ] High contrast.~ ~- [ ] Talkback.~ ~- [ ] Languages with large words or with letters/accents not frequently used in English.~ ~- [ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)~ ~- [ ] Large and small screen sizes. (Tablet and smaller phones)~ ~- [ ] Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)~

dangermattic commented 2 weeks ago
1 Warning
:warning: This PR is assigned to the milestone 24.8. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by :no_entry_sign: Danger

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

wpmobilebot commented 2 weeks ago
Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20724-4bbea9c
Commit4bbea9c44aef6983e23c3729e0eda72c66865290
Direct Downloadjetpack-prototype-build-pr20724-4bbea9c.apk
Note: Google Login is not supported on these builds.
wpmobilebot commented 2 weeks ago
WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20724-4bbea9c
Commit4bbea9c44aef6983e23c3729e0eda72c66865290
Direct Downloadwordpress-prototype-build-pr20724-4bbea9c.apk
Note: Google Login is not supported on these builds.