wordpress-mobile / WordPress-Android

WordPress for Android
http://android.wordpress.org
GNU General Public License v2.0
2.99k stars 1.32k forks source link

Consider dropping `android:screenOrientation` parameter #21084

Closed wzieba closed 3 days ago

wzieba commented 4 months ago

Expected behavior

No activity in AndroidManifest.xml files has android:screenOrientation

Actual behavior

Some activities have defined either landscape or portrait modes. Citing Android Lint documentation:

Should not restrict activity to fixed orientation. This may not be suitable for different form factors, causing the app to be letterboxed.

Steps to reproduce the behavior

Remove DiscouragedApi issues from baseline and run a lint task (after #21082 is merged).

dangermattic commented 4 months ago

Thanks for reporting! 👍

nbradbury commented 3 months ago

Note that #20957 corrected this for login, but we still have these locked into portrait:

And this one locked into landscape: