Bump :gravatar to 2.0.1

AdamGrzybkowski commented 1 month ago

This PR bumps the Gravatar SDK to the latest 2.0.0 version.

On the outside, we made some updates to our public API but under the hood, the avatar upload endpoint was also updated to a v3 version.

Note: I have an issue with one screen during sign-up flow SignupEpilogueFragment. When I run wasabi flavor this screen automatically finishes and moves to the next one. Testing the jalapeno build seems to work fine. I've also asked @hamorillo to test this and it worked okay for him on both variants. Any idea what's happening? I can see the the wasabi build is getting some AccountAction.PUSH_SETTINGS updates.

To Test:

Avatar change flow from the MeFragment and SignupEpilogueFragment.

In the sign-up flow on the SignupEpilogueFragment screen.
Tap on the add avatar button, pick one and upload.
Once logged in, go to the Me tab.
Tap on the avatar.
Follow the flow to update the avatar.
Go to Gravatar.com and make sure that the avatar was indeed set.

Regression Notes

Potential unintended areas of impact
- no

PR Submission Checklist:

~- [ ] I have completed the Regression Notes.~

[x] I have considered adding accessibility improvements for my changes.
[x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

~- [ ] WordPress.com sites and self-hosted Jetpack sites.~ ~- [ ] Portrait and landscape orientations.~ ~- [ ] Light and dark modes.~ ~- [ ] Fonts: Larger, smaller and bold text.~ ~- [ ] High contrast.~ ~- [ ] Talkback.~ ~- [ ] Languages with large words or with letters/accents not frequently used in English.~ ~- [ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)~ ~- [ ] Large and small screen sizes. (Tablet and smaller phones)~ ~- [ ] Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)~

The update shouldn't affect the UI so the above scenarios are not valid.

wpmobilebot commented 1 month ago

Project dependencies changes

The following changes in project dependencies were detected (configuration wordpressVanillaReleaseRuntimeClasspath):

list

``` New Dependencies com.squareup.moshi:moshi:1.15.1 com.squareup.moshi:moshi-kotlin:1.15.1 com.squareup.retrofit2:converter-moshi:2.11.0 org.jetbrains.kotlin:kotlin-reflect:1.8.22 Upgraded Dependencies com.gravatar:gravatar:2.0.1, (changed from 1.0.0) ```

tree

```diff -+--- project :libs:login -| \--- com.gravatar:gravatar:1.0.0 -| +--- com.squareup.retrofit2:retrofit:2.9.0 -> 2.11.0 -| | \--- com.squareup.okhttp3:okhttp:3.14.9 -> 4.12.0 (*) -| +--- com.squareup.retrofit2:converter-gson:2.9.0 -| | +--- com.squareup.retrofit2:retrofit:2.9.0 -> 2.11.0 (*) -| | \--- com.google.code.gson:gson:2.8.5 -> 2.11.0 (*) -| +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.7.3 -> 1.8.1 (*) -| +--- com.squareup.okhttp3:okhttp:4.12.0 (*) -| \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.22 -> 2.0.21 (*) ++--- project :libs:image-editor +| \--- com.google.android.material:material:1.12.0 +| \--- org.jetbrains.kotlin:kotlin-bom:1.8.22 +| \--- org.jetbrains.kotlin:kotlin-reflect:1.8.22 (c) -+--- com.gravatar:gravatar:1.0.0 (*) -\--- com.zendesk:support:5.1.2 - \--- com.zendesk:support-providers:5.1.2 - \--- com.zendesk:core:4.0.9 - \--- com.squareup.retrofit2:converter-gson:2.9.0 (*) ++--- project :libs:login +| \--- com.gravatar:gravatar:2.0.1 +| +--- com.squareup.moshi:moshi-kotlin:1.15.1 +| | +--- com.squareup.moshi:moshi:1.15.1 +| | | +--- com.squareup.okio:okio:3.7.0 -> 3.9.0 (*) +| | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.10 (*) +| | +--- org.jetbrains.kotlin:kotlin-reflect:1.8.21 -> 1.8.22 +| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.21 (*) +| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.10 (*) +| +--- com.squareup.retrofit2:retrofit:2.11.0 +| | \--- com.squareup.okhttp3:okhttp:3.14.9 -> 4.12.0 (*) +| +--- com.squareup.retrofit2:converter-moshi:2.11.0 +| | +--- com.squareup.retrofit2:retrofit:2.11.0 (*) +| | \--- com.squareup.moshi:moshi:1.15.1 (*) +| +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.7.3 -> 1.8.1 (*) +| +--- com.squareup.okhttp3:okhttp:4.12.0 (*) +| \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.25 -> 2.0.21 (*) ++--- com.gravatar:gravatar:2.0.1 (*) +\--- com.zendesk:support:5.1.2 + \--- com.zendesk:support-providers:5.1.2 + \--- com.zendesk:core:4.0.9 + \--- com.squareup.retrofit2:converter-gson:2.9.0 + +--- com.squareup.retrofit2:retrofit:2.9.0 -> 2.11.0 (*) + \--- com.google.code.gson:gson:2.8.5 -> 2.11.0 (*) ```

wpmobilebot commented 1 month ago

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr21311-1ee70bb
	Commit	1ee70bb7a8dda3956a576ad3e8a5bfd37d6b8f48
	Direct Download	`wordpress-prototype-build-pr21311-1ee70bb.apk`

Note: Google Login is not supported on these builds.

wpmobilebot commented 1 month ago

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr21311-1ee70bb
	Commit	1ee70bb7a8dda3956a576ad3e8a5bfd37d6b8f48
	Direct Download	`jetpack-prototype-build-pr21311-1ee70bb.apk`

Note: Google Login is not supported on these builds.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 39.50%. Comparing base (ae41f3f) to head (1ee70bb).

Files with missing lines	Patch %	Lines
...java/org/wordpress/android/util/WPAvatarUtils.java	0.00%	3 Missing :warning:
...a/org/wordpress/android/login/util/AvatarHelper.kt	0.00%	3 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## trunk #21311 +/- ## ======================================= Coverage 39.50% 39.50% ======================================= Files 2120 2120 Lines 99438 99438 Branches 15282 15282 ======================================= Hits 39281 39281 Misses 56675 56675 Partials 3482 3482 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nbradbury commented 1 month ago

@AdamGrzybkowski I tested the flow with the Me fragment and it all worked as expected, but I can't seem to get SignupEpilogueFragment to appear regardless of the build variant. What do I need to do to get that to show?

AdamGrzybkowski commented 4 weeks ago

@AdamGrzybkowski I tested the flow with the Me fragment and it all worked as expected, but I can't seem to get SignupEpilogueFragment to appear regardless of the build variant. What do I need to do to get that to show?

@nbradbury I was actually hoping you would help me with this screen as I also struggle with it.

I mentioned it in the description:

Note: I have an issue with one screen during sign-up flow SignupEpilogueFragment. When I run wasabi flavor this screen automatically finishes and moves to the next one. Testing the jalapeno build seems to work fine.

Here's how it looks for me:

https://github.com/user-attachments/assets/63294887-a883-4e5c-b160-f6005d4ce2ce

There's this Dialog with Updating account copy that's triggered by something and then the screen is closed.

AdamGrzybkowski commented 4 weeks ago

@hamorillo Given that the Signup screen works for you, would you mind testing this as well?