wordpress-mobile / WordPress-Android

WordPress for Android
http://android.wordpress.org
GNU General Public License v2.0
2.99k stars 1.32k forks source link

[Localization] Fix Remote Libraries Strings Paths #21313

Closed ParaskP7 closed 1 month ago

ParaskP7 commented 1 month ago

Similar to this WCAndroid PR, this PR updates the android_download_file_by_version(...) Fastfile action and import keys to fix a localization related issues related to versioning.

This is a leftover from the Version Catalogs migration work (PR).

FYI: During a WCAndroid release, the complete_code_freeze workflow failed due to the fact that the old, non-version-catalogs related versions couldn't be referenced any more. The same will apply for this project when a new release will commence. This change addresses that. Apologies for any inconvenience. πŸ™


To Test:

This is going to be tested live via the newest WCAndroid release (reference). If everything goes well there we can assume that this change is going to work on this project as well.


Regression Notes

  1. Potential unintended areas of impact

    • Localization is still failing during release code freeze.
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • See To test section.
  3. What automated tests I added (or what prevented me from doing so)

    • N/A

PR Submission Checklist: N/A


Testing Checklist (strike-out the not-applying and unnecessary ones): N/A

dangermattic commented 1 month ago
1 Message
:book: This PR has the Releases label: some checks will be skipped.

Generated by :no_entry_sign: Danger

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

wpmobilebot commented 1 month ago
WordPressπŸ“² You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21313-e628bb5
Commite628bb563d57e8d8f1c041bfd7f947d8a7ff9e8f
Direct Downloadwordpress-prototype-build-pr21313-e628bb5.apk
Note: Google Login is not supported on these builds.
wpmobilebot commented 1 month ago
JetpackπŸ“² You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21313-e628bb5
Commite628bb563d57e8d8f1c041bfd7f947d8a7ff9e8f
Direct Downloadjetpack-prototype-build-pr21313-e628bb5.apk
Note: Google Login is not supported on these builds.
ParaskP7 commented 1 month ago

FYI: @JorgeMucientes just confirmed with me that this update here actually worked on WCAndroid, so it is safe to assume that merging this will also work for this project too. As such, I will proceed with merging. πŸš€