Closed dcalhoun closed 1 month ago
1 Message | |
---|---|
:book: | This PR is still a Draft: some checks will be skipped. |
Generated by :no_entry_sign: Danger
App Name | WordPress | |
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr21324-826ea23 | |
Commit | 826ea2300a6dc63ba3e26265c70e1a5553513597 | |
Direct Download | wordpress-prototype-build-pr21324-826ea23.apk |
App Name | Jetpack | |
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr21324-826ea23 | |
Commit | 826ea2300a6dc63ba3e26265c70e1a5553513597 | |
Direct Download | jetpack-prototype-build-pr21324-826ea23.apk |
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 40.23%. Comparing base (
5d09cff
) to head (826ea23
). Report is 10265 commits behind head on trunk.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@dcalhoun Do you have a site I can use to test this? Also, I'm not sure from the description what I should expect to see. Perhaps a video would help?
@dcalhoun Do you have a site I can use to test this? Also, I'm not sure from the description what I should expect to see. Perhaps a video would help?
WordPress.com's Choose a Theme’s Style should provide additional context. The block editor should render content using a theme's styles—i.e., what-you-see-is-what-you-get. You can observe this same feature in the web editor, where the block editor's background color will match your theme's background color, the block editor's text color will match your theme's text color, etc.
An Atomic or jurassic.ninja site should allow for selecting a theme style. Happy to invite you to one of my testing sites, if that is preferred. Just let me know.
The block editor should render content using a theme's styles—i.e., what-you-see-is-what-you-get. You can observe this same feature in the web editor, where the block editor's background color will match your theme's background color, the block editor's text color will match your theme's text color, etc.
Thanks for the context. I thought I needed to use a specific block-related theme for this, but I see otherwise. I'll get back to reviewing this.
Provide experimental support for the editor WYSIWYG feature.
Fixes https://github.com/Automattic/dotcom-forge/issues/9450.
Testing Instructions
experimental_block_editor
experimental_block_editor_theme_styles
experimental_block_editor_theme_styles
flag.Regression Notes
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):