wordpress-mobile / WordPress-Android

WordPress for Android
http://android.wordpress.org
GNU General Public License v2.0
2.99k stars 1.32k forks source link

Material 3 bar code & QR code scanners #21330

Closed nbradbury closed 1 month ago

nbradbury commented 1 month ago

Fixes #21329

This PR converts the QR code & bar code scanners to Material3. To test:

dangermattic commented 1 month ago
1 Warning
:warning: View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
1 Message
:book: This PR is still a Draft: some checks will be skipped.

Generated by :no_entry_sign: Danger

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

wpmobilebot commented 1 month ago
Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21330-96226d9
Commit96226d981ae898799cc963f9f5e2ee7b76b901d6
Direct Downloadjetpack-prototype-build-pr21330-96226d9.apk
Note: Google Login is not supported on these builds.
wpmobilebot commented 1 month ago
WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21330-96226d9
Commit96226d981ae898799cc963f9f5e2ee7b76b901d6
Direct Downloadwordpress-prototype-build-pr21330-96226d9.apk
Note: Google Login is not supported on these builds.
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 39.31%. Comparing base (c5427bc) to head (96226d9). Report is 32 commits behind head on trunk.

Files with missing lines Patch % Lines
.../android/ui/barcodescanner/BarcodeScannerScreen.kt 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## trunk #21330 +/- ## ======================================= Coverage 39.31% 39.31% ======================================= Files 2121 2121 Lines 98292 98292 Branches 15225 15225 ======================================= Hits 38644 38644 Misses 56213 56213 Partials 3435 3435 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dcalhoun commented 1 month ago

@nbradbury when I tap Scan Login Code I see a full-screen camera view with no other UI besides the default Android bottom bar (overview, home, back buttons). Is that the expected appearance?

Also, when I attempt to scan the QR code, the app does not acknowledge its presence or proceed with authentication in the web browser—i.e., it appears to be broken. I am using a non-2FA account. Is the flow succeeding for you?

I tested using a Samsung Galaxy S20 running Android 13.

nbradbury commented 1 month ago

when I tap Scan Login Code I see a full-screen camera view with no other UI besides the default Android bottom bar (overview, home, back buttons). Is that the expected appearance?

I don't have much insight into this feature, but this is how it works in trunk.

Also, when I attempt to scan the QR code, the app does not acknowledge its presence or proceed with authentication in the web browser—i.e., it appears to be broken. I am using a non-2FA account. Is the flow succeeding for you?

If I use the app to scan the code from my laptop, it does then proceed to login on the laptop. Regardless, it's a weird experience, and I'm doubtful of its usefulness.

nbradbury commented 1 month ago

@dcalhoun Thanks for the review! I agree with you about the problems with this feature and have opened this issue.