Closed nbradbury closed 1 month ago
1 Warning | |
---|---|
:warning: | View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity. |
1 Message | |
---|---|
:book: | This PR is still a Draft: some checks will be skipped. |
Generated by :no_entry_sign: Danger
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
App Name | Jetpack | |
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr21330-96226d9 | |
Commit | 96226d981ae898799cc963f9f5e2ee7b76b901d6 | |
Direct Download | jetpack-prototype-build-pr21330-96226d9.apk |
App Name | WordPress | |
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr21330-96226d9 | |
Commit | 96226d981ae898799cc963f9f5e2ee7b76b901d6 | |
Direct Download | wordpress-prototype-build-pr21330-96226d9.apk |
Attention: Patch coverage is 0%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 39.31%. Comparing base (
c5427bc
) to head (96226d9
). Report is 32 commits behind head on trunk.
Files with missing lines | Patch % | Lines |
---|---|---|
.../android/ui/barcodescanner/BarcodeScannerScreen.kt | 0.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@nbradbury when I tap Scan Login Code I see a full-screen camera view with no other UI besides the default Android bottom bar (overview, home, back buttons). Is that the expected appearance?
Also, when I attempt to scan the QR code, the app does not acknowledge its presence or proceed with authentication in the web browser—i.e., it appears to be broken. I am using a non-2FA account. Is the flow succeeding for you?
I tested using a Samsung Galaxy S20 running Android 13.
when I tap Scan Login Code I see a full-screen camera view with no other UI besides the default Android bottom bar (overview, home, back buttons). Is that the expected appearance?
I don't have much insight into this feature, but this is how it works in trunk
.
Also, when I attempt to scan the QR code, the app does not acknowledge its presence or proceed with authentication in the web browser—i.e., it appears to be broken. I am using a non-2FA account. Is the flow succeeding for you?
If I use the app to scan the code from my laptop, it does then proceed to login on the laptop. Regardless, it's a weird experience, and I'm doubtful of its usefulness.
@dcalhoun Thanks for the review! I agree with you about the problems with this feature and have opened this issue.
Fixes #21329
This PR converts the QR code & bar code scanners to Material3. To test: