Post FluxC vendor improvements: remove unused Wiremock files, migrate to local version catalog

wordpress-mobile / WordPress-Android

WordPress for Android

http://android.wordpress.org

GNU General Public License v2.0

2.99k stars 1.33k forks source link

Post FluxC vendor improvements: remove unused Wiremock files, migrate to local version catalog #21353

Closed wzieba closed 3 weeks ago

wzieba commented 1 month ago

Description

This PR adds several, post FluxC vendor improvements:

remove */wc/* WireMock files that are simply not needed (I should've exclude them during migration but I haven't noticed them)
clean gradle.properties-example of vendored modules
migrate fluxc modules to use local version catalog instead of shared dependency catalog As with the FluxC merge, this doesn't seem to add many benefits and makes updating dependencies and keeping consise dependency tree more difficult.

Testing

This is build-focus work. Green light from CI is completely fine. Mind the dependency diff tree comment: this PR shouldn't introduce changes to the runtime classpath.

dangermattic commented 1 month ago

	1 Warning
:warning:	PR is not assigned to a milestone.

Generated by :no_entry_sign: Danger

wpmobilebot commented 1 month ago

Project dependencies changes

The following changes in project dependencies were detected (configuration wordpressVanillaReleaseRuntimeClasspath):

list

``` ```

tree

```diff \--- project :libs:fluxc - +--- com.android.volley:volley:1.1.1 -> 1.2.1 + +--- com.android.volley:volley:1.2.1 - +--- org.wordpress:utils:3.12.0 -> 3.14.0 + +--- org.wordpress:utils:3.14.0 - +--- com.google.code.gson:gson:2.8.5 -> 2.11.0 (*) + +--- com.google.code.gson:gson:2.11.0 (*) - +--- org.apache.commons:commons-text:1.10.0 -> 1.12.0 (*) + +--- org.apache.commons:commons-text:1.12.0 (*) - \--- com.google.dagger:dagger:2.51.1 -> 2.52 + \--- com.google.dagger:dagger:2.50 -> 2.52 ```

wpmobilebot commented 1 month ago

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr21353-cfa1d78
	Commit	cfa1d78ab732c94c80b376840cf04312e3ab9720
	Direct Download	`wordpress-prototype-build-pr21353-cfa1d78.apk`

Note: Google Login is not supported on these builds.

wpmobilebot commented 1 month ago

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr21353-cfa1d78
	Commit	cfa1d78ab732c94c80b376840cf04312e3ab9720
	Direct Download	`jetpack-prototype-build-pr21353-cfa1d78.apk`

Note: Google Login is not supported on these builds.

sonarcloud[bot] commented 3 weeks ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

ParaskP7 commented 3 weeks ago

👍 on https://github.com/wordpress-mobile/WordPress-Android/pull/21353#issuecomment-2435711726, but also, me seeing dagger pointing to 2.52, it made me wonder why... Only to then understand that this is coming from the login module. Having the dagger version being driven by this module instead of version catalogs seems a bit odd, right. On a separate PR, do you maybe have any plans to move these version into version catalogs as well? 🤔

FYI: This work is actually being address here: #21367 ✅