wordpress-mobile / WordPress-Android

WordPress for Android
http://android.wordpress.org
GNU General Public License v2.0
2.99k stars 1.33k forks source link

Match iOS Feedback Form Tracks Events #21360

Closed nbradbury closed 1 month ago

nbradbury commented 1 month ago

Fixes #21348

Previously on Android we tracked when the feedback form was opened using FEEDBACK_FORM_OPENED, but on iOS this is APP_REVIEWS_FEEDBACK_SCREEN_OPENED. This is because initially the feedback form was part of the in-app reviews feature.

This PR updates that event to match iOS, and to match iOS it also adds these two events:

To test:

dangermattic commented 1 month ago
1 Message
:book: This PR is still a Draft: some checks will be skipped.

Generated by :no_entry_sign: Danger

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

wpmobilebot commented 1 month ago
WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21360-0543e0b
Commit0543e0be240f53742586f40ec80fd9b9a1492ae7
Direct Downloadwordpress-prototype-build-pr21360-0543e0b.apk
Note: Google Login is not supported on these builds.
wpmobilebot commented 1 month ago
Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21360-0543e0b
Commit0543e0be240f53742586f40ec80fd9b9a1492ae7
Direct Downloadjetpack-prototype-build-pr21360-0543e0b.apk
Note: Google Login is not supported on these builds.
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 39.30%. Comparing base (da5752d) to head (0543e0b). Report is 2 commits behind head on trunk.

Files with missing lines Patch % Lines
...roid/ui/main/feedbackform/FeedbackFormViewModel.kt 0.00% 4 Missing :warning:
...ava/org/wordpress/android/ui/ActivityLauncher.java 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## trunk #21360 +/- ## ========================================== - Coverage 39.31% 39.30% -0.01% ========================================== Files 2121 2121 Lines 98303 98307 +4 Branches 15227 15227 ========================================== Hits 38644 38644 - Misses 56224 56228 +4 Partials 3435 3435 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.