Migrate `login` to version catalogs

wzieba commented 3 weeks ago

Description

This PR migrates login module to use local version catalog and unifies setup of per-project repositories for easier management.

Testing

This PR introduces build-related changes - a green light from CI and empty list of dependency diff should be just fine.

wpmobilebot commented 3 weeks ago

Project dependencies changes

The following changes in project dependencies were detected (configuration wordpressVanillaReleaseRuntimeClasspath):

list

``` Upgraded Dependencies com.google.dagger:hilt-android:2.52, (changed from 2.50) com.google.dagger:hilt-core:2.52, (changed from 2.50) ```

tree

```diff +--- project :libs:fluxc -| \--- com.google.dagger:dagger:2.50 -> 2.52 +| \--- com.google.dagger:dagger:2.52 +--- project :libs:login -| +--- com.google.android.gms:play-services-auth:18.1.0 -> 20.7.0 +| +--- com.google.android.gms:play-services-auth:20.4.1 -> 20.7.0 -| +--- org.wordpress:utils:3.5.0 -> 3.14.0 (*) +| +--- org.wordpress:utils:3.14.0 (*) -| +--- com.gravatar:gravatar:0.2.0 -> 1.0.0 +| +--- com.gravatar:gravatar:1.0.0 -| \--- androidx.core:core:1.12.0 -> 1.13.1 (*) +| \--- androidx.core:core:1.13.1 (*) -+--- com.google.dagger:dagger-android-support:2.50 -> 2.52 (*) ++--- com.google.dagger:dagger-android-support:2.52 (*) -\--- com.google.dagger:hilt-android:2.50 - +--- com.google.dagger:dagger:2.50 -> 2.52 (*) - +--- com.google.dagger:dagger-lint-aar:2.50 -> 2.52 - +--- com.google.dagger:hilt-core:2.50 - | +--- com.google.dagger:dagger:2.50 -> 2.52 (*) - | +--- com.google.code.findbugs:jsr305:3.0.2 - | \--- javax.inject:javax.inject:1 - +--- com.google.code.findbugs:jsr305:3.0.2 - +--- androidx.activity:activity:1.5.1 -> 1.9.3 (*) - +--- androidx.annotation:annotation:1.2.0 -> 1.9.0 (*) - +--- androidx.annotation:annotation-experimental:1.3.1 -> 1.4.1 (*) - +--- androidx.fragment:fragment:1.5.1 -> 1.8.4 (*) - +--- androidx.lifecycle:lifecycle-common:2.5.1 -> 2.8.5 (*) - +--- androidx.lifecycle:lifecycle-viewmodel:2.5.1 -> 2.8.5 (*) - +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.5.1 -> 2.8.5 (*) - +--- androidx.savedstate:savedstate:1.2.0 -> 1.2.1 (*) - +--- javax.inject:javax.inject:1 - \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.20 -> 2.0.0 (*) +\--- com.google.dagger:hilt-android:2.52 + +--- com.google.dagger:dagger:2.52 (*) + +--- com.google.dagger:dagger-lint-aar:2.52 + +--- com.google.dagger:hilt-core:2.52 + | +--- com.google.dagger:dagger:2.52 (*) + | +--- com.google.code.findbugs:jsr305:3.0.2 + | \--- javax.inject:javax.inject:1 + +--- com.google.code.findbugs:jsr305:3.0.2 + +--- androidx.activity:activity:1.5.1 -> 1.9.3 (*) + +--- androidx.annotation:annotation:1.3.0 -> 1.9.0 (*) + +--- androidx.annotation:annotation-experimental:1.3.1 -> 1.4.1 (*) + +--- androidx.fragment:fragment:1.5.1 -> 1.8.4 (*) + +--- androidx.lifecycle:lifecycle-common:2.5.1 -> 2.8.5 (*) + +--- androidx.lifecycle:lifecycle-viewmodel:2.5.1 -> 2.8.5 (*) + +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.5.1 -> 2.8.5 (*) + +--- androidx.savedstate:savedstate:1.2.0 -> 1.2.1 (*) + +--- javax.inject:javax.inject:1 + \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.24 -> 2.0.0 (*) ```

wpmobilebot commented 3 weeks ago

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr21367-a948c05
	Commit	a948c0592d9336c2cef8e451398c83cdf38b7c50
	Direct Download	`wordpress-prototype-build-pr21367-a948c05.apk`

Note: Google Login is not supported on these builds.

wpmobilebot commented 3 weeks ago

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr21367-a948c05
	Commit	a948c0592d9336c2cef8e451398c83cdf38b7c50
	Direct Download	`jetpack-prototype-build-pr21367-a948c05.apk`

Note: Google Login is not supported on these builds.

ParaskP7 commented 3 weeks ago

FYI: @wzieba , in the previous #21353 PR I forgot to mention about this androidx-paging-runtime version and the recommendation to use androidx-paging instead. The runtime suffix can be removed and only be utilized on the dependency itself, which could be runtime related, ktx related, or any other androidx-paging related dependency. However, the same androidx-paging version should apply to all these dependencies, this version shouldn't be specific to runtime. Hope that makes sense. 🙏

PS: As an example, check this androidx-room version you also migrated in that PR.

wzieba commented 3 weeks ago

Thanks for both reviews @ParaskP7 ! 🙌