wordpress-mobile / WordPress-Android

WordPress for Android
http://android.wordpress.org
GNU General Public License v2.0
2.99k stars 1.33k forks source link

Site monitoring Material3 #21396

Closed nbradbury closed 2 weeks ago

nbradbury commented 3 weeks ago

This PR updates the Site monitoring feature to Material3. It only involves changes to a single file, but those changes were more involved than previous M3 PRs. To test:

Note: As mentioned here on Slack, we have an issue with this feature where the WebViews aren't showing any data. This is a pre-existing issue unrelated to this PR.

dangermattic commented 3 weeks ago
1 Warning
:warning: PR is not assigned to a milestone.

Generated by :no_entry_sign: Danger

wpmobilebot commented 3 weeks ago
Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21396-f07664a
Commitf07664a7901b50ce46c8311282700db4c200ebc7
Direct Downloadjetpack-prototype-build-pr21396-f07664a.apk
Note: Google Login is not supported on these builds.
wpmobilebot commented 3 weeks ago
WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21396-f07664a
Commitf07664a7901b50ce46c8311282700db4c200ebc7
Direct Downloadwordpress-prototype-build-pr21396-f07664a.apk
Note: Google Login is not supported on these builds.
codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 39.30%. Comparing base (b9405f4) to head (f07664a). Report is 18 commits behind head on trunk.

Files with missing lines Patch % Lines
...ndroid/ui/sitemonitor/SiteMonitorParentActivity.kt 0.00% 9 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## trunk #21396 +/- ## ========================================== - Coverage 39.31% 39.30% -0.01% ========================================== Files 2121 2122 +1 Lines 98320 98329 +9 Branches 15231 15233 +2 ========================================== Hits 38651 38651 - Misses 56230 56239 +9 Partials 3439 3439 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
4.8% Duplication on New Code

See analysis details on SonarCloud