feat: GutenbergKit Media Library support

dcalhoun commented 3 weeks ago

Description

Add support for attaching Media Library items to media blocks—Image, Gallery, Video, etc.

Testing Instructions

See https://github.com/wordpress-mobile/GutenbergKit/pull/36.

Regression Notes

Potential unintended areas of impact Regressions in Gutenberg Mobile or Aztec media attachments.
What I did to test those areas of impact (or what existing automated tests I relied on) Manually tested attaching media.
What automated tests I added (or what prevented me from doing so) Deemed unnecessary for the experimental GutenbergKit editor.

PR Submission Checklist:

[x] I have completed the Regression Notes.
[x] I have considered adding accessibility improvements for my changes.
[x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

[ ] WordPress.com sites and self-hosted Jetpack sites.
[ ] Portrait and landscape orientations.
[ ] Light and dark modes.
[ ] Fonts: Larger, smaller and bold text.
[ ] High contrast.
[ ] Talkback.
[ ] Languages with large words or with letters/accents not frequently used in English.
[ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
[ ] Large and small screen sizes. (Tablet and smaller phones)
[ ] Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

dangermattic commented 3 weeks ago

	1 Warning
:warning:	PR is not assigned to a milestone.

Generated by :no_entry_sign: Danger

wpmobilebot commented 3 weeks ago

Project dependencies changes

The following changes in project dependencies were detected (configuration wordpressVanillaReleaseRuntimeClasspath):

list

``` Upgraded Dependencies org.wordpress.gutenbergkit:android:trunk-c62f3f03a4fdcd31263e9cc014f7a4c65c18131a, (changed from trunk-a58a46f3fbb892f311b562e3c122d7ef4ebbfe33) ```

tree

```diff +--- project :libs:editor -| \--- org.wordpress.gutenbergkit:android:trunk-a58a46f3fbb892f311b562e3c122d7ef4ebbfe33 +| \--- org.wordpress.gutenbergkit:android:trunk-c62f3f03a4fdcd31263e9cc014f7a4c65c18131a -\--- org.wordpress.gutenbergkit:android:trunk-a58a46f3fbb892f311b562e3c122d7ef4ebbfe33 (*) +\--- org.wordpress.gutenbergkit:android:trunk-c62f3f03a4fdcd31263e9cc014f7a4c65c18131a (*) ```

wpmobilebot commented 3 weeks ago

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr21399-caf348f
	Commit	caf348f3614204a7fac243237c967eda62aae4ff
	Direct Download	`wordpress-prototype-build-pr21399-caf348f.apk`

Note: Google Login is not supported on these builds.

wpmobilebot commented 3 weeks ago

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr21399-caf348f
	Commit	caf348f3614204a7fac243237c967eda62aae4ff
	Direct Download	`jetpack-prototype-build-pr21399-caf348f.apk`

Note: Google Login is not supported on these builds.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 8.33333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 39.50%. Comparing base (ae41f3f) to head (caf348f). Report is 99 commits behind head on trunk.

Files with missing lines	Patch %	Lines
...ress/android/ui/photopicker/MediaPickerLauncher.kt	0.00%	6 Missing :warning:
...rdpress/android/ui/mediapicker/MediaPickerSetup.kt	16.66%	5 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## trunk #21399 +/- ## ======================================= Coverage 39.50% 39.50% ======================================= Files 2120 2120 Lines 99438 99438 Branches 15282 15282 ======================================= Hits 39281 39281 Misses 56675 56675 Partials 3482 3482 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.