wordpress-mobile / WordPress-Android

WordPress for Android
http://android.wordpress.org
GNU General Public License v2.0
2.99k stars 1.33k forks source link

Material 3: Voice to content #21427

Closed nbradbury closed 2 weeks ago

nbradbury commented 2 weeks ago

This PR converts the "Voice to content" feature to Material3. To test:

https://github.com/user-attachments/assets/5d374395-8de7-491b-a178-24bdc389457a

dangermattic commented 2 weeks ago
1 Warning
:warning: PR is not assigned to a milestone.

Generated by :no_entry_sign: Danger

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

wpmobilebot commented 2 weeks ago
WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21427-96cf3ab
Commit96cf3ab247d02d4e63a0ebab668881a56dc47121
Direct Downloadwordpress-prototype-build-pr21427-96cf3ab.apk
Note: Google Login is not supported on these builds.
wpmobilebot commented 2 weeks ago
Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21427-96cf3ab
Commit96cf3ab247d02d4e63a0ebab668881a56dc47121
Direct Downloadjetpack-prototype-build-pr21427-96cf3ab.apk
Note: Google Login is not supported on these builds.
codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 39.30%. Comparing base (236ee0d) to head (96cf3ab). Report is 9 commits behind head on trunk.

Files with missing lines Patch % Lines
.../android/ui/voicetocontent/VoiceToContentScreen.kt 0.00% 19 Missing :warning:
...rdpress/android/ui/voicetocontent/MicToStopIcon.kt 0.00% 4 Missing :warning:
...ss/android/ui/voicetocontent/WaveformVisualizer.kt 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## trunk #21427 +/- ## ======================================= Coverage 39.30% 39.30% ======================================= Files 2121 2121 Lines 98326 98326 Branches 15233 15233 ======================================= Hits 38649 38649 Misses 56238 56238 Partials 3439 3439 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nbradbury commented 2 weeks ago

I noted the UI is unexpectedly obscured from content overflow scrolling.

Oh, interesting. It looks like that happens on smaller screens. Which device are you testing with?

dcalhoun commented 2 weeks ago

I noted the UI is unexpectedly obscured from content overflow scrolling.

Oh, interesting. It looks like that happens on smaller screens. Which device are you testing with?

A Samsung Galaxy S20 5G FE. I consider it a fairly large device screen.

nbradbury commented 2 weeks ago

A Samsung Galaxy S20 5G FE. I consider it a fairly large device screen.

Yes, that is a large screen. I'm not sure why the overlap is happening, then, but since it happens in trunk I'll file a separate issue for it. Thanks!