wordpress-mobile / WordPress-Android

WordPress for Android
http://android.wordpress.org
GNU General Public License v2.0
2.99k stars 1.32k forks source link

Updated constraintlayout version to fix #21429 #21430

Closed nbradbury closed 2 weeks ago

nbradbury commented 3 weeks ago

Fixes #21429

This PR fixes a crash that was introduced by a recent ConstraintLayout update. The fix was simply to update that library again. Note that I had to fix a "private resource" lint error caused by DomainItem for the app to build.

To test:

dangermattic commented 3 weeks ago
2 Warnings
:warning: strings.xml files should only be updated on release branches, when the translations are downloaded by our automation.
:warning: PR is not assigned to a milestone.

Generated by :no_entry_sign: Danger

wpmobilebot commented 3 weeks ago

Project dependencies changes

The following changes in project dependencies were detected (configuration wordpressVanillaReleaseRuntimeClasspath):

list ``` New Dependencies androidx.constraintlayout:constraintlayout-compose-android:1.1.0 Upgraded Dependencies androidx.constraintlayout:constraintlayout-compose:1.1.0, (changed from 1.0.1) ```
tree ```diff -\--- androidx.constraintlayout:constraintlayout-compose:1.0.1 - +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.10 -> 1.9.10 (*) - +--- androidx.compose.ui:ui:1.0.0 -> 1.7.5 (*) - +--- androidx.compose.ui:ui-unit:1.0.0 -> 1.7.5 (*) - +--- androidx.compose.ui:ui-util:1.0.0 -> 1.7.5 (*) - +--- androidx.compose.foundation:foundation-layout:1.0.0 -> 1.7.5 (*) - +--- androidx.compose.foundation:foundation:1.0.0 -> 1.7.5 (*) - +--- androidx.compose.material:material:1.0.0 -> 1.7.5 (*) - \--- androidx.constraintlayout:constraintlayout-core:1.0.4 -> 1.1.0 (*) +\--- androidx.constraintlayout:constraintlayout-compose:1.1.0 + \--- androidx.constraintlayout:constraintlayout-compose-android:1.1.0 + +--- androidx.annotation:annotation:1.8.1 -> 1.9.1 (*) + +--- androidx.collection:collection:1.4.2 -> 1.4.4 (*) + +--- androidx.compose.foundation:foundation:1.7.2 -> 1.7.5 (*) + +--- androidx.compose.foundation:foundation-layout:1.7.2 -> 1.7.5 (*) + +--- androidx.compose.ui:ui:1.7.2 -> 1.7.5 (*) + +--- androidx.compose.ui:ui-unit:1.7.2 -> 1.7.5 (*) + +--- androidx.compose.ui:ui-util:1.7.2 -> 1.7.5 (*) + +--- androidx.constraintlayout:constraintlayout-core:1.1.0 (*) + \--- androidx.core:core-ktx:1.5.0 -> 1.13.1 (*) ```
wpmobilebot commented 3 weeks ago
Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21430-a69fa04
Commita69fa04a3e539c5fc3fa330d04a103c9f847838b
Direct Downloadjetpack-prototype-build-pr21430-a69fa04.apk
Note: Google Login is not supported on these builds.
wpmobilebot commented 3 weeks ago
WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21430-a69fa04
Commita69fa04a3e539c5fc3fa330d04a103c9f847838b
Direct Downloadwordpress-prototype-build-pr21430-a69fa04.apk
Note: Google Login is not supported on these builds.
nbradbury commented 3 weeks ago

Reverting to a Draft due to lint issues with the library update.

sonarcloud[bot] commented 3 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

nbradbury commented 3 weeks ago

Note: To get this to pass lint, I had to change lint.xml to treat ObsoleteLintCustomCheck as a warning rather than an error. See this Slack thread for details.

wzieba commented 2 weeks ago

hi @nbradbury ! The code looks good to me - I couldn't test it as I don't see Blaze card on my end (Jetpack app) but code itself look good and safe to merge IMO! 👍