Closed nbradbury closed 2 weeks ago
2 Warnings | |
---|---|
:warning: | strings.xml files should only be updated on release branches, when the translations are downloaded by our automation. |
:warning: | PR is not assigned to a milestone. |
Generated by :no_entry_sign: Danger
The following changes in project dependencies were detected (configuration wordpressVanillaReleaseRuntimeClasspath
):
App Name | Jetpack | |
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr21430-a69fa04 | |
Commit | a69fa04a3e539c5fc3fa330d04a103c9f847838b | |
Direct Download | jetpack-prototype-build-pr21430-a69fa04.apk |
App Name | WordPress | |
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr21430-a69fa04 | |
Commit | a69fa04a3e539c5fc3fa330d04a103c9f847838b | |
Direct Download | wordpress-prototype-build-pr21430-a69fa04.apk |
Reverting to a Draft due to lint issues with the library update.
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Note: To get this to pass lint, I had to change lint.xml
to treat ObsoleteLintCustomCheck
as a warning rather than an error. See this Slack thread for details.
hi @nbradbury ! The code looks good to me - I couldn't test it as I don't see Blaze card on my end (Jetpack app) but code itself look good and safe to merge IMO! 👍
Fixes #21429
This PR fixes a crash that was introduced by a recent
ConstraintLayout
update. The fix was simply to update that library again. Note that I had to fix a "private resource" lint error caused byDomainItem
for the app to build.To test:
trunk
go to "My Site," tap the ☰ icon on the Blaze card, and select "Learn more"