wordpress-mobile / WordPress-Android

WordPress for Android
http://android.wordpress.org
GNU General Public License v2.0
2.99k stars 1.33k forks source link

[Tooling] Use `buildkite_pipeline_upload` action to inline Buildkite release pipelines #21437

Closed iangmaia closed 1 week ago

iangmaia commented 2 weeks ago

Description

iOS counterpart: https://github.com/wordpress-mobile/WordPress-iOS/pull/23782 Related: pdccJN-xR-p2

This PR uses the release-toolkit action buildkite_pipeline_upload implemented on https://github.com/wordpress-mobile/release-toolkit/pull/597.

Our release pipelines (such as complete-code-freeze, finalize-release, etc) usually require to start a separate pipeline to make a release build. The changes in this PR will result in add the steps of a release pipeline to the currently running build, without starting a new build altogether.

Testing information

Testing information

I've added (and later reverted) a test commit 95c00cf720d596d59559e56335d5b42ca311e1b0 to test the complete_code_freeze lane.

This is a test build created using the Buildkite Web UI directly with PIPELINE=complete-code-freeze.yml:

This PR can be tested in a similar way to the test above: creating a branch off this one, slightly modifying a release lane to prevent side effects and running the build directly on Buildkite.

dangermattic commented 2 weeks ago
1 Warning
:warning: This PR is assigned to the milestone 25.5. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by :no_entry_sign: Danger

wpmobilebot commented 2 weeks ago
Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21437-accc6e3
Commitaccc6e306151dc8d77a2abad4d082486ecd85d3c
Direct Downloadjetpack-prototype-build-pr21437-accc6e3.apk
Note: Google Login is not supported on these builds.
wpmobilebot commented 2 weeks ago
WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21437-accc6e3
Commitaccc6e306151dc8d77a2abad4d082486ecd85d3c
Direct Downloadwordpress-prototype-build-pr21437-accc6e3.apk
Note: Google Login is not supported on these builds.
sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

iangmaia commented 1 week ago

Looking good.

I noticed there are two pipelines one for betas and one for releases. The difference seems to be minimal, so I wonder if it'd be worth logging a task to consolidate them [...] The main difference is in which Fastlane lane they call, but I think that can be tidied up with a lane consolidation, too.

I've also noticed the same! Also the priority is another difference (not big enough to have different pipeline files, if you ask me). All other projects follow the approach of a single pipeline, so I agree this is an improvement here that can be done on another PR.