wordpress-mobile / WordPress-Android

WordPress for Android
http://android.wordpress.org
GNU General Public License v2.0
2.99k stars 1.33k forks source link

Material 3: My Site Personalization #21441

Closed nbradbury closed 1 week ago

nbradbury commented 1 week ago

This PR updates the Personalization activity to Material 3. To test:

Note that the switches used on this screen differ in appearance from those currently in trunk. This is expected and due to Material 3 changing the switch style.

person-after-light person-after-dark

dangermattic commented 1 week ago
1 Warning
:warning: PR is not assigned to a milestone.

Generated by :no_entry_sign: Danger

sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

wpmobilebot commented 1 week ago
WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21441-da18a69
Commitda18a69eb43a3aad6f206e262976baccb66235d6
Direct Downloadwordpress-prototype-build-pr21441-da18a69.apk
Note: Google Login is not supported on these builds.
wpmobilebot commented 1 week ago
Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21441-da18a69
Commitda18a69eb43a3aad6f206e262976baccb66235d6
Direct Downloadjetpack-prototype-build-pr21441-da18a69.apk
Note: Google Login is not supported on these builds.
codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 39.30%. Comparing base (b3945a1) to head (da18a69). Report is 52 commits behind head on trunk.

Files with missing lines Patch % Lines
.../mysite/personalization/PersonalizationActivity.kt 0.00% 21 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## trunk #21441 +/- ## ========================================== - Coverage 39.30% 39.30% -0.01% ========================================== Files 2121 2121 Lines 98326 98333 +7 Branches 15233 15235 +2 ========================================== Hits 38649 38649 - Misses 56238 56245 +7 Partials 3439 3439 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nbradbury commented 1 week ago

I will note that the toggle elements have no description, so navigating controls1 with a screen reader is near impossible

You're right. I know we have quite a few accessibility issues with the Android app, but this one is especially bad. I'll file an issue for it and start working on it.