wordpress-mobile / WordPress-Android

WordPress for Android
http://android.wordpress.org
GNU General Public License v2.0
2.99k stars 1.33k forks source link

Personalization accessibility #21445

Closed nbradbury closed 1 week ago

nbradbury commented 1 week ago

Fixes #21444 - As noted here, our personalization cards are impossible to navigate with a screen reader. This PR aims to resolve that.

To test:

I also added a better contentDescription to the Shortcuts section.

dangermattic commented 1 week ago
2 Warnings
:warning: strings.xml files should only be updated on release branches, when the translations are downloaded by our automation.
:warning: PR is not assigned to a milestone.

Generated by :no_entry_sign: Danger

sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

wpmobilebot commented 1 week ago
WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21445-e5d90e9
Commite5d90e90dbc91e2a15777d3178f8a8d5e6912c78
Direct Downloadwordpress-prototype-build-pr21445-e5d90e9.apk
Note: Google Login is not supported on these builds.
wpmobilebot commented 1 week ago
Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21445-e5d90e9
Commite5d90e90dbc91e2a15777d3178f8a8d5e6912c78
Direct Downloadjetpack-prototype-build-pr21445-e5d90e9.apk
Note: Google Login is not supported on these builds.
codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 39.50%. Comparing base (ae41f3f) to head (e5d90e9). Report is 27 commits behind head on trunk.

Files with missing lines Patch % Lines
.../mysite/personalization/PersonalizationActivity.kt 0.00% 15 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## trunk #21445 +/- ## ======================================= Coverage 39.50% 39.50% ======================================= Files 2120 2120 Lines 99438 99438 Branches 15282 15282 ======================================= Hits 39281 39281 Misses 56675 56675 Partials 3482 3482 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.