wordpress-mobile / WordPress-Android

WordPress for Android
http://android.wordpress.org
GNU General Public License v2.0
2.99k stars 1.33k forks source link

Make `wasabi` a default build type #21456

Closed wzieba closed 1 week ago

wzieba commented 1 week ago

Description

As wasabi is "preferred variant for developers", it should be selected by default when opening Android Studio. AGP reference: https://developer.android.com/reference/tools/gradle-api/8.7/com/android/build/api/dsl/ApplicationProductFlavor#isDefault()

Testing

Fresh clone the project and open it in AS: wasabi should be selected as the current build variant.

sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

wpmobilebot commented 1 week ago
Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21456-3b34197
Commit3b341978fc6d7ee56a07a0f1516ff5ee566edd75
Direct Downloadjetpack-prototype-build-pr21456-3b34197.apk
Note: Google Login is not supported on these builds.
wpmobilebot commented 1 week ago
WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21456-3b34197
Commit3b341978fc6d7ee56a07a0f1516ff5ee566edd75
Direct Downloadwordpress-prototype-build-pr21456-3b34197.apk
Note: Google Login is not supported on these builds.
wzieba commented 1 week ago

I wonder if we need to also explicitly mark the debug build type as default

It seems we don't - we haven't in the past, and when you open project, it's debug by default. I guess this is default behavior of AS, which makes sense - opening project in IDE prefers a debug variant if available.

This change triggers me again to ask another question, do we really need those product flavors,

I don't know - there probably was a reason to introduce them by product team, I'd leave the decission for them.