wordpress-mobile / WordPress-Android

WordPress for Android
http://android.wordpress.org
GNU General Public License v2.0
2.99k stars 1.33k forks source link

Stats: remove avg "view more" link #21457

Closed nbradbury closed 1 week ago

nbradbury commented 1 week ago

Partially resolves #21451

As noted in the issue, tapping this link in stats does nothing because this line of code explicitly states to do nothing.

stats

It turns out this was simply due to fixing a warning about a non-exhaustive when clause.

nothing

We don't have a screen for average daily views and creating one doesn't seem like a priority, so this PR simply removes the "View more" link. I've filed #21458 as a reminder that we should add that screen at some point to match iOS.

dangermattic commented 1 week ago
1 Warning
:warning: PR is not assigned to a milestone.

Generated by :no_entry_sign: Danger

wpmobilebot commented 1 week ago
Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21457-ba6d8d6
Commitba6d8d6c650a918c74d29f59b4a58b9cf462f196
Direct Downloadjetpack-prototype-build-pr21457-ba6d8d6.apk
Note: Google Login is not supported on these builds.
wpmobilebot commented 1 week ago
WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21457-ba6d8d6
Commitba6d8d6c650a918c74d29f59b4a58b9cf462f196
Direct Downloadwordpress-prototype-build-pr21457-ba6d8d6.apk
Note: Google Login is not supported on these builds.
sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 39.50%. Comparing base (a81d9ef) to head (ba6d8d6). Report is 12 commits behind head on trunk.

Files with missing lines Patch % Lines
...resh/lists/detail/PostAverageViewsPerDayUseCase.kt 66.66% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## trunk #21457 +/- ## ======================================= Coverage 39.50% 39.50% ======================================= Files 2119 2119 Lines 99437 99437 Branches 15282 15282 ======================================= Hits 39281 39281 Misses 56674 56674 Partials 3482 3482 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.