Closed dcalhoun closed 1 week ago
2 Warnings | |
---|---|
:warning: | strings.xml files should only be updated on release branches, when the translations are downloaded by our automation. |
:warning: | PR is not assigned to a milestone. |
Generated by :no_entry_sign: Danger
App Name | Jetpack | |
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr21459-e4838b2 | |
Commit | e4838b247ad756333df38820a9e5947b6dfc0335 | |
Direct Download | jetpack-prototype-build-pr21459-e4838b2.apk |
App Name | WordPress | |
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr21459-e4838b2 | |
Commit | e4838b247ad756333df38820a9e5947b6dfc0335 | |
Direct Download | wordpress-prototype-build-pr21459-e4838b2.apk |
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 39.50%. Comparing base (
acb4a47
) to head (e4838b2
). Report is 35 commits behind head on trunk.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I opted to build an implementation similar to the Privacy settings, relying upon the existing Java rather than building a new Kotlin view. I welcome any feedback on the approach.
I think this is fine.
@dcalhoun This looks good to me. I do think it's a bid odd to have "Debug settings" on the Me tab but "Experimental features" on the App Settings screen. To me they should be together on App Settings since they're related.
That's not something that has to be done in this PR, just wanted to get your thoughts on that.
I do think it's a bid odd to have "Debug settings" on the Me tab but "Experimental features" on the App Settings screen. To me they should be together on App Settings since they're related.
@nbradbury understandable, I agree their separation is odd and I paused to consider this during implementation. Ultimately, I placed Experimental features based on the iOS implementation, where it resides beneath App settings. In contrast to Android, iOS places Debug beneath App Settings, so both Experimental Features and Debug reside next to one another.
I will also note that Debug is not visible to users, it is only present in non-production builds.
I'm open to relocating Experimental features in a separate PR, if that is preferred.
I would prefer to see those both under App Settings. I do realize Debug settings isn't seen by users, but if we keep these two in different places I believe it will always bug me :)
Expose select experimental features for users, allowing for user feedback.
Closes https://github.com/Automattic/dotcom-forge/issues/9730.
Screenshot
![experimental-features](https://github.com/user-attachments/assets/6b6fcfa3-050c-404e-b2d6-8b7d9ffb86e9)
Screen recording
To Test:
1 - Toggle experimental features
2 - Experimental features sync with remote feature flag UI
Regression Notes
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):